Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ayn7c-0003lq-MS for pgsql-hackers@arkaria.postgresql.org; Fri, 06 May 2016 21:17:16 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1ayn7c-00035K-9T for pgsql-hackers@arkaria.postgresql.org; Fri, 06 May 2016 21:17:16 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ayn6H-0001ai-1P for pgsql-hackers@postgresql.org; Fri, 06 May 2016 21:15:53 +0000 Received: from mx-out.zmailcloud.com ([192.198.85.98] helo=mx-out-1.zmailcloud.com) by makus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ayn6E-0003m6-9r for pgsql-hackers@postgresql.org; Fri, 06 May 2016 21:15:51 +0000 Received: from smtp.01.com (smtp.01.com [10.10.0.43]) by mx-out-1.zmailcloud.com (Postfix) with ESMTP id BDF5B563E3B; Fri, 6 May 2016 16:15:49 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by smtp-out-1.01.com (Postfix) with ESMTP id AB646A029E; Fri, 6 May 2016 16:15:49 -0500 (CDT) X-Virus-Scanned: amavisd-new at smtp-out-1.01.com Received: from smtp.01.com ([127.0.0.1]) by localhost (smtp-out-1.01.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7nDxDAJIJ7Rb; Fri, 6 May 2016 16:15:49 -0500 (CDT) Received: from smtp.01.com (localhost [127.0.0.1]) by smtp-out-1.01.com (Postfix) with ESMTP id 68FB3A0326; Fri, 6 May 2016 16:15:49 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by smtp-out-1.01.com (Postfix) with ESMTP id 35267A02BC; Fri, 6 May 2016 16:15:49 -0500 (CDT) X-Virus-Scanned: amavisd-new at smtp-out-1.01.com Received: from smtp.01.com ([127.0.0.1]) by localhost (smtp-out-1.01.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Fyn4EdhkXuHs; Fri, 6 May 2016 16:15:49 -0500 (CDT) Received: from redhat.com (c-98-246-109-153.hsd1.or.comcast.net [98.246.109.153]) by smtp-out-1.01.com (Postfix) with ESMTPSA id 55A59A029E; Fri, 6 May 2016 16:15:48 -0500 (CDT) Subject: Re: Reviewing freeze map code To: Andres Freund References: <572D0309.4090402@commandprompt.com> <20160506205012.ipuhvctss2ozzs6m@alap3.anarazel.de> <572D0471.3040009@commandprompt.com> <20160506205824.ysst7mk3k26ztok2@alap3.anarazel.de> <572D062E.5030308@agliodbs.com> <572D068F.3050608@commandprompt.com> <20160506210806.f6pnk6ueirjqrlmu@alap3.anarazel.de> <572D082C.3050704@agliodbs.com> <20160506211254.4rknrxpjzav7f66r@alap3.anarazel.de> Cc: "Joshua D. Drake" , Robert Haas , Masahiko Sawada , "pgsql-hackers@postgresql.org" From: Josh berkus Message-ID: <572D0983.6030109@agliodbs.com> Date: Fri, 6 May 2016 14:15:47 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 05/06/2016 02:12 PM, Andres Freund wrote: > On 2016-05-06 14:10:04 -0700, Josh berkus wrote: >> On 05/06/2016 02:08 PM, Andres Freund wrote: >> >>> It bothers me more than it probably should: Nobdy tests, reviews, >>> whatever a complex patch with significant data-loss potential. But as >>> soon somebody dares to mention an option name... >> >> Definitely more than it should, because it's gonna happen *every* time. >> >> https://en.wikipedia.org/wiki/Law_of_triviality > > Doesn't mean it should not be frowned upon. Or made light of, hence my post. Personally I don't care what the option is called, as long as we have docs for it. For the serious testing, does anyone have a good technique for creating loads which would stress-test vacuum freezing? It's hard for me to come up with anything which wouldn't be very time-and-resource intensive (like running at 10,000 TPS for a week). -- -- Josh Berkus Red Hat OSAS (any opinions are my own) -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers