Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooJus-0006Z8-Oq for pgsql-hackers@arkaria.postgresql.org; Fri, 28 Oct 2022 07:36:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ooJur-0008QP-Ly for pgsql-hackers@arkaria.postgresql.org; Fri, 28 Oct 2022 07:36:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooJur-0008QG-CA for pgsql-hackers@lists.postgresql.org; Fri, 28 Oct 2022 07:36:33 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooJun-0002hL-DF for pgsql-hackers@lists.postgresql.org; Fri, 28 Oct 2022 07:36:32 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 704915C012A; Fri, 28 Oct 2022 03:36:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 28 Oct 2022 03:36:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1666942585; x= 1667028985; bh=Nxs2hw6oIoPyPhxzRKUhrUkdGrykTVHbmsAnKYlDglQ=; b=A jGqoOlXdgs+Xaw5M/yhc0BYPFEvOD7eT+WybCmX88f908rzq8CyFtfH55sgm8Tsl itzXjQftljtRL16ApI9b+3UNpUuiOwBb2YrhioGOdOSjWEnrKTFMPQudKliFFRXL YXdVHr7e4stWZFctJ0NWz45O0wuiKwtKAdQTGFPETMNZVzvnluCTgs5Jptx7GBfF rGWGxBMQPizT4DyxY18aqHLmEq6mGDvECJxDz5y/aR1nF2fEv5fKtkf2appzw3H2 dwzjic1PT8hvUX6Ci2KxXLcOiRr2gos+12VFWwO5aPsCWwSepSidrju4dno8Vp/8 qsGUb/n1N7LjdZV00DifA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdehgdduudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvghnth gvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrhhnpeehleffgeegudejteei hfelteduvdeifffhffdvjedvffegjeekudeludehudeifeenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghu thesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 28 Oct 2022 03:36:24 -0400 (EDT) Message-ID: <572ed6f8-a137-0a52-a35e-a48df95af6ed@enterprisedb.com> Date: Fri, 28 Oct 2022 09:36:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: Simplifying our Trap/Assert infrastructure Content-Language: en-US To: Michael Paquier Cc: Nathan Bossart , Tom Lane , pgsql-hackers@lists.postgresql.org References: <3928703.1665345117@sss.pgh.pa.us> <20221009210148.GA900071@nathanxps13> <20221012183620.GA1447761@nathanxps13> From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 27.10.22 09:23, Michael Paquier wrote: > Agreed, even if extensions could use these, it looks like any > out-of-core code using what's removed here would also gain in clarity. > This is logically fine (except for an indentation blip in > miscadmin.h?), so I have marked this entry as ready for committer. committed > Side note, rather unrelated to what's proposed here: would it be worth > extending AssertPointerAlignment() for the frontend code? Would there be a use for that? It's currently only used in the atomics code.