Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p33L6-0003iU-TO for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Dec 2022 22:56:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1p33L5-0000TQ-GD for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Dec 2022 22:56:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p33L5-0000TG-62 for pgsql-hackers@lists.postgresql.org; Wed, 07 Dec 2022 22:56:31 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p33Ky-00025D-TA for pgsql-hackers@lists.postgresql.org; Wed, 07 Dec 2022 22:56:30 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 2B7MuKks005740; Wed, 7 Dec 2022 17:56:20 -0500 From: Tom Lane To: Andrew Dunstan cc: "David G. Johnston" , Corey Huinker , Andres Freund , Alvaro Herrera , Joe Conway , Robert Haas , Nikita Glukhov , PostgreSQL Hackers Subject: Re: Error-safe user functions In-reply-to: <1d17177a-08eb-f1f1-d870-f47a1763f351@dunslane.net> References: <20221205174231.6wpmbuxafnfzlbuh@alvherre.pgsql> <85e40849-4458-bbb9-62ee-d9e7faf0c7dc@dunslane.net> <3323802.1670263204@sss.pgh.pa.us> <3496391.1670276406@sss.pgh.pa.us> <20221205234734.sab3fuxy6q2sokjd@alap3.anarazel.de> <3518534.1670285891@sss.pgh.pa.us> <20221206005607.lxcrazckoalptwds@alap3.anarazel.de> <3523582.1670288815@sss.pgh.pa.us> <40ff1ed1-4245-e343-bffa-c7755b031492@dunslane.net> <3889877.1670358069@sss.pgh.pa.us> <4009543.1670422833@sss.pgh.pa.us> <6acddf68-7cb7-e9e7-a5a7-0abc87b3c55b@dunslane.net> <4111458.1670444176@sss.pgh.pa.us> <3211.1670452341@sss.pgh.pa.us> <1d17177a-08eb-f1f1-d870-f47a1763f351@dunslane.net> Comments: In-reply-to Andrew Dunstan message dated "Wed, 07 Dec 2022 17:50:34 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <5738.1670453780.1@sss.pgh.pa.us> Date: Wed, 07 Dec 2022 17:56:20 -0500 Message-ID: <5739.1670453780@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andrew Dunstan writes: > On 2022-12-07 We 17:32, Tom Lane wrote: >> Does it make sense to break 0003 into 4 separate commits, or is >> that overkill?) > No strong opinion about 0001 and 0002. I'm happy enough with them as > they are, but if you want to squash them that's ok. I wouldn't break up > 0003. I think we're going to end up committing the remaining work in > batches, although they would probably be a bit more thematically linked > than these. Yeah, we certainly aren't likely to do this work as one-commit-per-datatype going forward. I'm just wondering how to do these initial commits so that they provide good reference material. regards, tom lane