Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b37mj-0006MP-H1 for pgsql-hackers@arkaria.postgresql.org; Wed, 18 May 2016 20:09:37 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b37mi-0004LI-Iq for pgsql-hackers@arkaria.postgresql.org; Wed, 18 May 2016 20:09:36 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b37lI-0002jp-N4 for pgsql-hackers@postgresql.org; Wed, 18 May 2016 20:08:08 +0000 Received: from zmcc-5-mx.zmailcloud.com ([192.198.93.228]) by makus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b37lB-00053t-Oy for pgsql-hackers@postgresql.org; Wed, 18 May 2016 20:08:07 +0000 Received: from zmcc-5-mta-1.zmailcloud.com (127.37.197.104.bc.googleusercontent.com [104.197.37.127]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by zmcc-5-mx.zmailcloud.com (Postfix) with ESMTPS id 8A1D6520256; Wed, 18 May 2016 16:08:00 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by zmcc-5-mta-1.zmailcloud.com (Postfix) with ESMTP id 31538C2C66; Wed, 18 May 2016 20:08:00 +0000 (UTC) Received: from zmcc-5-mta-1.zmailcloud.com ([127.0.0.1]) by localhost (zmcc-5-mta-1.zmailcloud.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id CctYaBTSXNXs; Wed, 18 May 2016 20:07:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by zmcc-5-mta-1.zmailcloud.com (Postfix) with ESMTP id C5AE9C2CAA; Wed, 18 May 2016 20:07:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at zmcc-5-mta-1.zmailcloud.com Received: from zmcc-5-mta-1.zmailcloud.com ([127.0.0.1]) by localhost (zmcc-5-mta-1.zmailcloud.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id z1-h6qx4TFL0; Wed, 18 May 2016 20:07:59 +0000 (UTC) Received: from redhat.com (unknown [137.122.64.8]) by zmcc-5-mta-1.zmailcloud.com (Postfix) with ESMTPSA id 70796C2C66; Wed, 18 May 2016 20:07:59 +0000 (UTC) Subject: Re: Reviewing freeze map code To: Peter Geoghegan , Jeff Janes References: <20160517193208.GA169606@alvherre.pgsql> <573B8E6E.1070909@2ndquadrant.fr> <142e516d-2b66-1859-6733-aabd6ab9a272@archidevsys.co.nz> <648c400e-ff35-3f95-69cb-4a83f0158e7f@pgmasters.net> <573C714D.2060505@commandprompt.com> <573C77AF.8030201@joeconway.com> Cc: Joe Conway , Victor Yegorov , Robert Haas , "pgsql-hackers@postgresql.org" From: Josh berkus Message-ID: <573CCB9C.50705@agliodbs.com> Date: Wed, 18 May 2016 16:07:56 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 05/18/2016 03:51 PM, Peter Geoghegan wrote: > On Wed, May 18, 2016 at 8:52 AM, Jeff Janes wrote: >> How about going with something that says more about why we are doing >> it, rather than trying to describe in one or two words what it is >> doing? >> >> VACUUM (FORENSIC) >> >> VACUUM (DEBUG) >> >> VACUUM (LINT) > > +1 Maybe this is the wrong perspective. I mean, is there a reason we even need this option, other than a lack of any other way to do a full table scan to check for corruption, etc.? If we're only doing this for integrity checking, then maybe it's better if it becomes a function, which could be later extended with additional forensic features? -- -- Josh Berkus Red Hat OSAS (any opinions are my own) -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers