Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nME6Z-00060z-V3 for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Feb 2022 19:12:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nME6Y-0006Qa-UC for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Feb 2022 19:12:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nME6Y-0006QQ-LF for pgsql-hackers@lists.postgresql.org; Mon, 21 Feb 2022 19:12:14 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nME6W-0006g9-Fc for pgsql-hackers@postgresql.org; Mon, 21 Feb 2022 19:12:13 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 21LJC4YW575001; Mon, 21 Feb 2022 14:12:04 -0500 From: Tom Lane To: Florin Irion cc: Peter Eisentraut , Kyotaro Horiguchi , Shinya11.Kato@oss.nttdata.com, masao.fujii@oss.nttdata.com, bharath.rupireddyforpostgres@gmail.com, daniel@yesql.se, pgsql-hackers@postgresql.org Subject: Re: Emit a warning if the extension's GUC is set incorrectly In-reply-to: <4160911.1645222701@sss.pgh.pa.us> References: <9f5e96ca44891915f1d2736bea9fdf45@oss.nttdata.com> <83b33009-3a1b-9230-8f07-2115763c1853@enterprisedb.com> <20211221.100834.1297468238807011575.horikyota.ntt@gmail.com> <57009.1640107405@sss.pgh.pa.us> <116024.1640111629@sss.pgh.pa.us> <1640909.1640638123@sss.pgh.pa.us> <1902182.1640711215@sss.pgh.pa.us> <4160911.1645222701@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Fri, 18 Feb 2022 17:18:21 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <574999.1645470724.1@sss.pgh.pa.us> Date: Mon, 21 Feb 2022 14:12:04 -0500 Message-ID: <575000.1645470724@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I wrote: > Florin Irion writes: >> For what it's worth, I agree with throwing an ERROR if the placeholder is >> unrecognized. Initially, I didn't want to change too much the liberty of >> setting any placeholder, but mainly to not go unnoticed. > I also think that this is probably a good change to make. Hearing no objections, done. regards, tom lane