Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oEu5T-0005Ew-7F
	for pgsql-hackers@arkaria.postgresql.org; Fri, 22 Jul 2022 14:57:07 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oEu5S-00014v-3F
	for pgsql-hackers@arkaria.postgresql.org; Fri, 22 Jul 2022 14:57:06 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oEu5R-00014c-Qo
	for pgsql-hackers@lists.postgresql.org; Fri, 22 Jul 2022 14:57:05 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oEu5L-0001x7-Gu
	for pgsql-hackers@lists.postgresql.org; Fri, 22 Jul 2022 14:57:05 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 26MEtRMX575834;
	Fri, 22 Jul 2022 10:55:28 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>
cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Japin Li <japinli@hotmail.com>,
        Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
        Laurenz Albe <laurenz.albe@cybertec.at>,
        "smithpb2250@gmail.com" <smithpb2250@gmail.com>,
        "david.zhang@highgo.ca" <david.zhang@highgo.ca>,
        "pgsql-hackers@lists.postgresql.org"
 <pgsql-hackers@lists.postgresql.org>
Subject: Re: Support tab completion for upper character inputs in psql
In-reply-to: 
 <OS0PR01MB6113EA19F05E217C823B4CCAFB909@OS0PR01MB6113.jpnprd01.prod.outlook.com>
References: 
 <OS0PR01MB611303B647967B6949B759F1FB4E9@OS0PR01MB6113.jpnprd01.prod.outlook.com>
 <20210423.115812.900808736988307020.horikyota.ntt@gmail.com>
 <OS0PR01MB6113CA04E06D5BF221BC4FE2FB429@OS0PR01MB6113.jpnprd01.prod.outlook.com>
 <OS0PR01MB61136721363BD08576725F22FB089@OS0PR01MB6113.jpnprd01.prod.outlook.com>
 <80b093ae-88bd-8d8a-68b9-b535a3ab11be@enterprisedb.com>
 <OS0PR01MB61137C7B2B09C0431415B9DBFBD69@OS0PR01MB6113.jpnprd01.prod.outlook.com>
 <54bd7839-f463-ef03-f2d2-ccb8184b9b27@enterprisedb.com>
 <1068530.1641480996@sss.pgh.pa.us>
 <TYCPR01MB6128BD8EA1529F4270114C18FB4D9@TYCPR01MB6128.jpnprd01.prod.outlook.com>
 <MEYP282MB1669EAF2183E67EAF86F7F61B64D9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
 <TYCPR01MB6128D4933189A74AAD326F98FB4D9@TYCPR01MB6128.jpnprd01.prod.outlook.com>
 <c7fb9ad1-0b77-eda5-0055-02ee472e3a4a@enterprisedb.co! m>
 <3547066.1642272686@sss.pgh.pa.us>
 <OS0PR01MB6113C130461FB8A9DBA0DAEBFB5A9@OS0PR01MB6113.jpnprd01.prod.outlook.com>
 <17d022ce-2543-b4a3-2b55-fc04!
 ! ! ! ! ae87a220@enterprisedb.com>
 <OS0PR01MB6113DB08D8CEA4E214DA37BBFB5F9@OS0PR01MB6113.jpnprd01.prod.outlook.com>
 <2304294.1643152287@sss.pgh.pa.us> <2645164.1643315022@sss.pgh.pa.us>
 <OS0PR01MB611360D58EA41FC6557D92C0FB229@OS0PR01MB6113.jpnprd01.prod.outlook.com>
 <2771362.1643385796@sss.pgh.pa.us> <2805502.1643405157@sss.pgh.pa.us>
 <2818574.1643408192@sss.pgh.pa.us>
 <OS0PR01MB61130E73CFDB2C0E8FD1A892FB249@OS0PR01MB6113.jpnprd01.prod.outlook.com>
 <324281.1643567679@sss.pgh.pa.us>
 <OS0PR01MB6113EA19F05E217C823B4CCAFB909@OS0PR01MB6113.jpnprd01.prod.outlook.com>
Comments: In-reply-to "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>
	message dated "Fri, 22 Jul 2022 08:30:48 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <575832.1658501727.1@sss.pgh.pa.us>
Date: Fri, 22 Jul 2022 10:55:27 -0400
Message-ID: <575833.1658501727@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/575833.1658501727%40sss.pgh.pa.us>
Precedence: bulk

"tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com> writes:
> I think 02b8048 forgot to free some used memory. 
> Attached a tiny patch to fix it. Please have a check.

Right you are.  Inspired by that, I tried running some tab-completion
operations under valgrind, and found another nearby leak in
patternToSQLRegex.  Fixes pushed.

			regards, tom lane