Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1nwQSo-00037m-28
	for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Jun 2022 15:40:50 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1nwQSm-0002GM-CC
	for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Jun 2022 15:40:48 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1nwQSm-0002GC-2r
	for pgsql-hackers@lists.postgresql.org; Wed, 01 Jun 2022 15:40:48 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1nwQSj-0003F4-PJ
	for pgsql-hackers@lists.postgresql.org; Wed, 01 Jun 2022 15:40:47 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 251FegGB578877;
	Wed, 1 Jun 2022 11:40:42 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: plperl tests fail with latest Perl 5.36
In-reply-to: <87bkvcmn9i.fsf@wibble.ilmari.org>
References: <564579.1654093326@sss.pgh.pa.us>
 <87bkvcmn9i.fsf@wibble.ilmari.org>
Comments: In-reply-to =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?=
 <ilmari@ilmari.org>
	message dated "Wed, 01 Jun 2022 16:11:53 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <578875.1654098042.1@sss.pgh.pa.us>
Date: Wed, 01 Jun 2022 11:40:42 -0400
Message-ID: <578876.1654098042@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/578876.1654098042%40sss.pgh.pa.us>
Precedence: bulk

=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org> writes:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
>> Apparently 5.36 rejiggers warning classifications in a way that breaks
>> one of our test cases.  Perhaps we should switch it to some other
>> warning-triggering condition.

> The simplest thing is to actually use sort in void context,
> i.e. removing the `my $x = ` part from the test, see the attached.

Looks reasonable to me, but I'm hardly a Perl monk.  Anybody have
a different opinion?

			regards, tom lane