Content-Type: multipart/alternative;
 boundary="------------j5UWJJXJfK6huFCx84eMMJsa"
Message-ID: <57988cee-5cc8-44f9-981e-8d62e556f5c8@gmail.com>
Date: Sat, 1 Mar 2025 19:00:00 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Statistics Import and Export
To: Jeff Davis <pgsql@j-davis.com>, Andres Freund <andres@anarazel.de>,
 Corey Huinker <corey.huinker@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>,
 jian he <jian.universality@gmail.com>,
 Nathan Bossart <nathandbossart@gmail.com>, Bruce Momjian <bruce@momjian.us>,
 Matthias van de Meent <boekewurm+postgres@gmail.com>,
 Magnus Hagander <magnus@hagander.net>, Stephen Frost <sfrost@snowman.net>,
 Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
 Peter Smith <smithpb2250@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 alvherre@alvh.no-ip.org
References: <sdno5atrplq5b67vcx7x6fkzevwkzojd23izbguy2yma424wmp@siwbi3ijxdxs>
 <x5yo5ly5u3dhzfaq3hrzeqhju3io5zmwk4yqrkge3ywcflffck@ghbbgsfv56yb>
 <3670503.1740173078@sss.pgh.pa.us>
 <blezfpeafycxlizyynwvwzh2vywmklhvfqudhicjrccu4raqpx@4ttfufowc2vo>
 <3728741.1740178078@sss.pgh.pa.us>
 <CADkLM=f0a43aTd88xW4xCFayEF25g-7hTrHX_WhV40HyocsUGg@mail.gmail.com>
 <97b451228227c555be1a4f79c4a62ddec9a74f06.camel@j-davis.com>
 <CADkLM=ckXu5wzSQZ3Y_fvAaL8rZ+upZdSecBLf5FCTMj7M6T-A@mail.gmail.com>
 <b227c4fca29dfb893bb414ce6d84fc2377489ecc.camel@j-davis.com>
 <CADkLM=dRMC6t8gp9GVf6y6E_r5EChQjMAAh_vPyih_zMiq0zvA@mail.gmail.com>
 <y2d36zf6pl3n6ni6e4ctblu3a5iazi2dycknq53h2mjvp7lto4@hhww3h2qgdrw>
 <6af48508a32499a8be3398cafffd29fb6188c44b.camel@j-davis.com>
Content-Language: en-US
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <6af48508a32499a8be3398cafffd29fb6188c44b.camel@j-davis.com>
Archived-At: <https://www.postgresql.org/message-id/57988cee-5cc8-44f9-981e-8d62e556f5c8%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------j5UWJJXJfK6huFCx84eMMJsa
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hello Jeff,

26.02.2025 04:00, Jeff Davis wrote:
> I plan to commit the patches soon.

It looks like 8f427187d broke pg_dump on Cygwin:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fairywren&dt=2025-02-26%2010%3A03%3A07

As far as I can see, it exits prematurely here:
                float           reltuples = strtof(PQgetvalue(res, i, i_reltuples), NULL);

because of:
/*
  * Cygwin has a strtof() which is literally just (float)strtod(), which means
  * we get misrounding _and_ silent over/underflow. Using our wrapper doesn't
  * fix the misrounding but does fix the error checks, which cuts down on the
  * number of test variant files needed.
  */
#define HAVE_BUGGY_STRTOF 1
...
#ifdef HAVE_BUGGY_STRTOF
extern float pg_strtof(const char *nptr, char **endptr);
#define strtof(a,b) (pg_strtof((a),(b)))
#endif

and:
float
pg_strtof(const char *nptr, char **endptr)
{
...
     if (errno)
     {
         /* On error, just return the error to the caller. */
         return fresult;
     }
     else if ((*endptr == nptr) || isnan(fresult) ||
...

Best regards,
Alexander Lakhin
Neon (https://neon.tech)
--------------j5UWJJXJfK6huFCx84eMMJsa
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">Hello Jeff,<br>
      <br>
      26.02.2025 04:00, Jeff Davis wrote:<span
      style="white-space: pre-wrap">
</span></div>
    <blockquote type="cite"
cite="mid:6af48508a32499a8be3398cafffd29fb6188c44b.camel@j-davis.com">
      <pre wrap="" class="moz-quote-pre">I plan to commit the patches soon.
</pre>
    </blockquote>
    <br>
    It looks like 8f427187d broke pg_dump on Cygwin:<br>
<a class="moz-txt-link-freetext" href="https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fairywren&amp;dt=2025-02-26%2010%3A03%3A07">https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fairywren&amp;dt=2025-02-26%2010%3A03%3A07</a><br>
    <br>
    As far as I can see, it exits prematurely here:<br>
                   float           reltuples = strtof(PQgetvalue(res, i,
    i_reltuples), NULL);<br>
    <br>
    because of:<br>
    /*<br>
     * Cygwin has a strtof() which is literally just (float)strtod(),
    which means<br>
     * we get misrounding _and_ silent over/underflow. Using our wrapper
    doesn't<br>
     * fix the misrounding but does fix the error checks, which cuts
    down on the<br>
     * number of test variant files needed.<br>
     */<br>
    #define HAVE_BUGGY_STRTOF 1<br>
    ...<br>
    #ifdef HAVE_BUGGY_STRTOF<br>
    extern float pg_strtof(const char *nptr, char **endptr);<br>
    #define strtof(a,b) (pg_strtof((a),(b)))<br>
    #endif<br>
    <br>
    and:<br>
    float<br>
    pg_strtof(const char *nptr, char **endptr)<br>
    {<br>
    ...<br>
        if (errno)<br>
        {<br>
            /* On error, just return the error to the caller. */<br>
            return fresult;<br>
        }<br>
        else if ((*endptr == nptr) || isnan(fresult) ||<br>
    ...<br>
    <br>
    Best regards,<br>
    Alexander Lakhin
    <br>
    Neon (<a class="moz-txt-link-freetext" href="https://neon.tech">https://neon.tech</a>)
  </body>
</html>

--------------j5UWJJXJfK6huFCx84eMMJsa--