Subject: Re: WIP: About CMake v2
To: Christian Convey <christian.convey@gmail.com>
References: <4184974.kkvGJ5GoEX@dinodell> <1974943.sWDBYWy5U3@dinodell>
 <56096E15.3040602@gmx.net>
 <2319e612-6c78-4fd4-8ccb-e1fa1bc84c01@postgrespro.ru>
 <57B60263.4020501@kaltenbrunner.cc>
 <CAPfS4ZxpFsDYyBLnnVqXSdS=JWTDNxBaN0NaGRHZoNxy+=Voew@mail.gmail.com>
 <57B60792.3000307@kaltenbrunner.cc>
 <CAPfS4ZweZEzKdELrLQB0Ag61Qbn7RH2qm+nyPa_bodk6cJwG+w@mail.gmail.com>
Cc: Yury Zhuravlev <u.zhuravlev@postgrespro.ru>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
From: Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>
Message-ID: <57B60F85.3020602@kaltenbrunner.cc>
Date: Thu, 18 Aug 2016 21:41:57 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: 
 <CAPfS4ZweZEzKdELrLQB0Ag61Qbn7RH2qm+nyPa_bodk6cJwG+w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 08/18/2016 09:30 PM, Christian Convey wrote:
> Hi Karl,
> 
> I'll need to let Yury answer your original question regarding the best
> way to report CMake-related bugs.
> 
> Regarding the errors you're getting...  I just looked at CMake's
> online documentation regarding your "target_compile_definitions"
> error.
> 
> From what I can tell, the "target_compile_definition" property was
> introduced in CMake 2.8.11.  It sounds like your version of CMake is
> just a little too old.

Well - "too old" is a relative term - cmake 2.8.10 was released in only
october 2012 and cmake 2.8.11 in may 2013 so it is not even 4 years old,
the oldest currently supported (though for not much longer) postgresql
release 9.1 was released in september 2011 and 9.2 was also released
before october 2012.
So while Cmake compat might only make it for v10, I dont think that we
can depend on bleeding edge version like that for our buildtools...


> 
> Regarding how one can know the required CMake version: My modus
> operandi for CMake projects in general is (1) read the project's
> how-to-build docs, and if that's not heplful, (2) hope that the
> project's CMake files contain a "cmake_minimum_required" call to give
> me a clear error message.  I didn't find any such indication in Yuri's
> files, although perhaps I missed it.
> 
> 
> Yury: Would it make sense to add a call to "cmake_minimum_required" in
> one or more of your CMakeLists.txt files?

it would make sense nevertheless but I dont think that 2.8.11 is old
enough - looking at the release information and the feature compatibily
matrix it would seems we should more aim at something like 2.8.0 or 2.8.3...


Stefan


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers