Message-ID: <580D716B.1050600@lab.ntt.co.jp>
Date: Mon, 24 Oct 2016 11:26:51 +0900
From: Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.1.0
MIME-Version: 1.0
Subject: Minor code improvement to postgresGetForeignJoinPaths
Content-Type: multipart/mixed;
 boundary="------------090503060304030603090109"
To: pgsql-hackers@postgresql.org
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

This is a multi-part message in MIME format.
--------------090503060304030603090109
Content-Type: text/plain; charset=iso-2022-jp
Content-Transfer-Encoding: 7bit

Hi,

The last argument of create_foreignscan_path called by postgresGetForeignJoinPaths is
set to NULL, but it would be suitable to set it to NIL because the argument type is List.

Please find attached a patch.

Tatsuro Yamada
NTT Open Source Software Center

--------------090503060304030603090109
Content-Type: text/x-patch;
 name="postgresGetForeignJoinPaths.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="postgresGetForeignJoinPaths.patch"

diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c
index daf0438..a5de611 100644
--- a/contrib/postgres_fdw/postgres_fdw.c
+++ b/contrib/postgres_fdw/postgres_fdw.c
@@ -4331,7 +4331,7 @@ postgresGetForeignJoinPaths(PlannerInfo *root,
 									   NIL,		/* no pathkeys */
 									   NULL,	/* no required_outer */
 									   epq_path,
-									   NULL);	/* no fdw_private */
+									   NIL);	/* no fdw_private */
 
 	/* Add generated path into joinrel by add_path(). */
 	add_path(joinrel, (Path *) joinpath);

--------------090503060304030603090109
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------090503060304030603090109--