Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M309125=pgsql-hackers-arkari@postgresql.org>)
	id 1byun6-0005yQ-Sh
	for pgsql-hackers@arkaria.postgresql.org; Tue, 25 Oct 2016 06:00:52 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M309125=pgsql-hackers-arkari@postgresql.org>)
	id 1byun6-000389-A1
	for pgsql-hackers@arkaria.postgresql.org; Tue, 25 Oct 2016 06:00:52 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <yamada.tatsuro@lab.ntt.co.jp>)
	id 1byuli-0001Vk-AU
	for pgsql-hackers@postgresql.org; Tue, 25 Oct 2016 05:59:26 +0000
Received: from tama50.ecl.ntt.co.jp ([129.60.39.147])
	by magus.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <yamada.tatsuro@lab.ntt.co.jp>)
	id 1byule-0003PB-B0
	for pgsql-hackers@postgresql.org; Tue, 25 Oct 2016 05:59:25 +0000
Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154])
	by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id u9P5xHFi031975;
	Tue, 25 Oct 2016 14:59:17 +0900
Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1])
	by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 6EB4F5F594;
	Tue, 25 Oct 2016 14:59:17 +0900 (JST)
Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp
 [129.60.87.134])
	by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 61F0E5F592;
	Tue, 25 Oct 2016 14:59:17 +0900 (JST)
Received: from [127.0.0.1] (unknown [129.60.241.68])
	by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTP id 5013F400B28;
	Tue, 25 Oct 2016 14:59:17 +0900 (JST)
Message-ID: <580EF4B3.9090107@lab.ntt.co.jp>
Date: Tue, 25 Oct 2016 14:59:15 +0900
From: Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.1.0
MIME-Version: 1.0
Subject: Re: Minor code improvement to postgresGetForeignJoinPaths
References: <580D716B.1050600@lab.ntt.co.jp>
 <CAFjFpRftW1eXp3+y78pbF8jxAgE+JATJc3ATJzsJMN_fanVy1w@mail.gmail.com>
In-Reply-To: 
 <CAFjFpRftW1eXp3+y78pbF8jxAgE+JATJc3ATJzsJMN_fanVy1w@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
To: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
X-TM-AS-MML: disable
X-Pg-Spam-Score: -4.0 (----)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Hi Ashutosh,

> You are right. Every call except that one is using NIL, so better to
> fix it. The pattern was repeated in the recent aggregate pushdown
> support. Here's patch to fix create_foreignscan_path() call in
> add_foreign_grouping_paths() as well.

Thanks for the review!

Tatsuro Yamada
NTT Open Source Software Center




-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers