Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1sfoV5-00BT65-9O
	for pgsql-hackers@arkaria.postgresql.org; Sun, 18 Aug 2024 22:35:51 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1sfoV1-00Bv4f-Pz
	for pgsql-hackers@arkaria.postgresql.org; Sun, 18 Aug 2024 22:35:48 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tomas@vondra.me>)
	id 1sfoV0-00Bv4X-UN
	for pgsql-hackers@lists.postgresql.org; Sun, 18 Aug 2024 22:35:48 +0000
Received: from relay8-d.mail.gandi.net ([217.70.183.201])
	by magus.postgresql.org with esmtps  (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tomas@vondra.me>)
	id 1sfoUu-000LBl-Vh
	for pgsql-hackers@postgresql.org; Sun, 18 Aug 2024 22:35:46 +0000
Received: by mail.gandi.net (Postfix) with ESMTPSA id 6E9291BF203;
	Sun, 18 Aug 2024 22:35:40 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vondra.me; s=gm1;
	t=1724020540;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=HJ63WE/wVyIh8Goj4y2x65TseR0z29he2KAdPXytuOc=;
	b=XJ1Il7O7qDXdKmztSHw9R4Avw2zWBFto96eVan/XhXBG/fLRKj4niU82WgvmT2pFPQoz0V
	ek7adq1lsr7S8cYG0hc1bWI4YdvK5pdHm7AGC7U8yA7vbkHzJ9vY1AjP9J8r7g9HheR/KL
	7/ut7Z3czSLPaKFCTLWElC94dFSJRYQqyRHDmoaeNzbIgs5GH97PGtzLmXlDMw6lMOMju2
	xywoCCAFFh6U9HY+FGeSjCnimrPS/z8hbVInXlrFNnpH6hQLqSXlDLqvUjsv17uR7Sd69v
	YvRoZaGc/+5HJ5gBp9T4edT5wez8Kj/QsWYqdklUzOCd6Q4r7b2+dws0hpJmQg==
Message-ID: <580e7cd2-97fe-403c-be52-77a1bb8b9f7c@vondra.me>
Date: Mon, 19 Aug 2024 00:35:39 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Drop database command will raise "wrong tuple length" if
 pg_database tuple contains toast attribute.
From: Tomas Vondra <tomas@vondra.me>
To: Ayush Tiwari <ayushtiwari.slg01@gmail.com>, pgsql-hackers@postgresql.org
References: <CAJTYsWWNkCt+-UnMhg=BiCD3Mh8c2JdHLofPxsW3m2dkDFw8RA@mail.gmail.com>
 <3f705d5f-4085-458a-a47f-dee3472f7beb@vondra.me>
Content-Language: en-US
In-Reply-To: <3f705d5f-4085-458a-a47f-dee3472f7beb@vondra.me>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-GND-Sasl: tomas@vondra.me
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/580e7cd2-97fe-403c-be52-77a1bb8b9f7c%40vondra.me>
Precedence: bulk

On 8/16/24 13:26, Tomas Vondra wrote:
> Hi Ayush,
> 
> ...
> 
> So this fix seems reasonable.
> 

I've pushed this to all affected branches, except for 11 which is EOL.

I thought about adding a test, but I couldn't think of a TAP test where
this would really fit, and it didn't seem very practical to have a test
creating hundreds of roles. So I abandoned the idea.


Thanks for the report and the fix!

-- 
Tomas Vondra