Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wDotp-003Or9-2Q for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Apr 2026 19:30:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wDoto-00B01N-36 for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Apr 2026 19:30:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wDoto-00B01E-1g for pgsql-hackers@lists.postgresql.org; Fri, 17 Apr 2026 19:30:44 +0000 Received: from mail-dy1-x132f.google.com ([2607:f8b0:4864:20::132f]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wDotl-00000001hg5-3ejs for pgsql-hackers@postgresql.org; Fri, 17 Apr 2026 19:30:43 +0000 Received: by mail-dy1-x132f.google.com with SMTP id 5a478bee46e88-2d832f2f44cso1215410eec.0 for ; Fri, 17 Apr 2026 12:30:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20251104.gappssmtp.com; s=20251104; t=1776454239; x=1777059039; darn=postgresql.org; h=mime-version:user-agent:date:to:from:subject:message-id:from:to:cc :subject:date:message-id:reply-to; bh=GuE8BZHiR85lJnhCJqBsA3sQGPgdt9nIoy1u7qih4EI=; b=WoiBF/hEe1+wrgJ/MbdRJrddJSp4BSPYL/HhVY1MmumvuXagIpEjuBvf9NY34GLYvm xxupDeGBmaeEfsQ6tKMfGDbtsCT5k4vp6ceJOTLj4JZ1Sd6JwMEGalSm33IJGuL3ScDr Lm+wsPfxeIIPLQPLQCx7p4lvpcTAKBYdMKL62hWRO7kpSumrYQv7HME8Lzv5ouI0fori sKchKa09JER3NHcMsQubcg4/zrbeMJaKWU8GfDaxX9rQIIfrhDRUyzh/o7Apqsrbmcas mnsdhnoYA1KHmXkQDCzaQLmxZzpSMYqMPy5HroyvtF4SBCu1SNbkZ/542am5og73otAP dj5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776454239; x=1777059039; h=mime-version:user-agent:date:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GuE8BZHiR85lJnhCJqBsA3sQGPgdt9nIoy1u7qih4EI=; b=ovqXNiTq66wOD10JSSQyVf2JClyvhSXmfAvhioB9vIQCk/oJrThYE/LB1tLkapvJDR yfGN2p/NnOOBUmqWlU/iC4/aKqIK37htZ90smmEipeuNvurJT0QBT7JmwZCk3C7ntZ/p UKQUxmJ1djVWn/cHJHnRGD9m6PZonfn0dhaNQRy/bGC7H0Mi1TdVU5ZCcdKV2cUNVbAs dY4iJENCPowsKpjktmd7QwPj9W1SPpipRFQ/mEI9MeFzkLWSij66wIbJoGL+Lzkltt74 K7gZ66lriPQ+sFYoRrja8RIT65ZyA+1Xqe1vV87V0XSm0bWgM/OFruoDD/SeRADCT0H0 F2Lw== X-Gm-Message-State: AOJu0Yw3H4hk9797CRmHUzTlB17ad5t0Vi3tzgVsrV8fX5yJzkdtlGW7 iWzQbWK6kGno6y2nGug4kTwwPAV90PFI6LFsk5j2Sw4/lsBL8XuoBo86dMcC+F278EK15jEQUhB 4Zic= X-Gm-Gg: AeBDiesb/E00FcQ/M1wfd/xH7sSiIx6hfw6N4oOxeTDyttSS2fdlLkPeuW58T6FB4j7 jyX7rfDL3ZcTy2sISLVv6mDz/HU4H/0AtKe7mk211xaq37I6LvNTYFAkYXwecp1jDkUawgvf2CY kBwb8DJfvFimVdjryGsAr/dGd7PKOMxA7sV4Bo7VYrzbKzPpRGYat+tdCDzyLelEnO0XxL2wpz/ 7bz4Ooe0M1IoSXoOoKWncz5SJ1EHTL394cd6SZsptJ7RX+YlglmDsi8JVSLJJ78J3VWGnKhs4J7 5KQJbrsJVx9eRi8g7+fZJ/AK3Bh4dX5x1aIe8DXKIWkzV/+Zjx3lhat/bNhrESsWqkv4YVOTICp pJIN8ax7Zpvyl2rY2mTWyDxk+6V9xtvqFjyQwAtpYfLg83Ug9C/zxD6qoNmp5nuYp1jy7UURrWD po/Imx+zA5vdj3LlSnzaa/fch3nszAd0qO+/SaSo7FeT0NX8nUH4QIzKtQqYGqFQ== X-Received: by 2002:a05:693c:2b08:b0:2d3:2983:c87c with SMTP id 5a478bee46e88-2e464ea4f80mr2273104eec.1.1776454239259; Fri, 17 Apr 2026 12:30:39 -0700 (PDT) Received: from jeff-laptop.lan (c-24-7-19-3.hsd1.ca.comcast.net. [24.7.19.3]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e539fa3cecsm3465235eec.6.2026.04.17.12.30.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 12:30:38 -0700 (PDT) Message-ID: <581a72ff452bb045ba83bbe3c6cf4467702d4f0f.camel@j-davis.com> Subject: small cleanup patches for collation code From: Jeff Davis To: pgsql-hackers@postgresql.org Date: Fri, 17 Apr 2026 12:30:37 -0700 Content-Type: multipart/mixed; boundary="=-Lb2wDrzrRvFxln6PhoJb" User-Agent: Evolution 3.52.3-0ubuntu1.1 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=-Lb2wDrzrRvFxln6PhoJb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Two patches attached. 0001 fixes a style issue. Backport because it eliminates a warning in the 'update-unicode' target. 0002 looks like a bug, but is not a real issue because there are no callers that pass srclen=3D=3D-1, aside from a test (which fails to fail). So it's just cleanup, but it seems worth backporting. Regards, Jeff Davis --=-Lb2wDrzrRvFxln6PhoJb Content-Disposition: attachment; filename*0=v1-0001-style-define-parameterless-functions-as-foo-void.patc; filename*1=h Content-Type: text/x-patch; name="v1-0001-style-define-parameterless-functions-as-foo-void.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSA0NjczZDhjN2EzMWIyNDk3MGU2MzcxYzRmMmZiM2E1ZTA5OTQwOWRjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIERhdmlzIDxqZWZmQGotZGF2aXMuY29tPgpEYXRlOiBU aHUsIDE2IEFwciAyMDI2IDE2OjMwOjA2IC0wNzAwClN1YmplY3Q6IFtQQVRDSCB2MSAxLzJdIHN0 eWxlOiBkZWZpbmUgcGFyYW1ldGVybGVzcyBmdW5jdGlvbnMgYXMgZm9vKHZvaWQpLgoKQXZvaWRz IHdhcm5pbmcgaW4gJ3VwZGF0ZS11bmljb2RlJyBidWlsZCB0YXJnZXQuIFNpbWlsYXIgdG8KMTEx NzFmZTFmYy4KCkJhY2twYXRjaC10aHJvdWdoOiAxNwotLS0KIHNyYy9jb21tb24vdW5pY29kZS9j YXNlX3Rlc3QuYyAgICAgfCAyICstCiBzcmMvY29tbW9uL3VuaWNvZGUvY2F0ZWdvcnlfdGVzdC5j IHwgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvc3JjL2NvbW1vbi91bmljb2RlL2Nhc2VfdGVzdC5jIGIvc3JjL2NvbW1v bi91bmljb2RlL2Nhc2VfdGVzdC5jCmluZGV4IGZiMTU5YzFjMjdjLi5lMzRmNzAwZDljNCAxMDA2 NDQKLS0tIGEvc3JjL2NvbW1vbi91bmljb2RlL2Nhc2VfdGVzdC5jCisrKyBiL3NyYy9jb21tb24v dW5pY29kZS9jYXNlX3Rlc3QuYwpAQCAtMzI5LDcgKzMyOSw3IEBAIHRmdW5jX2ZvbGQoY2hhciAq ZHN0LCBzaXplX3QgZHN0c2l6ZSwgY29uc3QgY2hhciAqc3JjLAogfQogCiBzdGF0aWMgdm9pZAot dGVzdF9jb252ZXJ0X2Nhc2UoKQordGVzdF9jb252ZXJ0X2Nhc2Uodm9pZCkKIHsKIAkvKiB0ZXN0 IHN0cmluZyB3aXRoIG5vIGNhc2UgY2hhbmdlcyAqLwogCXRlc3RfY29udmVydCh0ZnVuY19sb3dl ciwgIuKImuKIniIsICLiiJriiJ4iKTsKZGlmZiAtLWdpdCBhL3NyYy9jb21tb24vdW5pY29kZS9j YXRlZ29yeV90ZXN0LmMgYi9zcmMvY29tbW9uL3VuaWNvZGUvY2F0ZWdvcnlfdGVzdC5jCmluZGV4 IDJiNDIyMDAxMjA5Li5mZmI5ZDQyZDcwNCAxMDA2NDQKLS0tIGEvc3JjL2NvbW1vbi91bmljb2Rl L2NhdGVnb3J5X3Rlc3QuYworKysgYi9zcmMvY29tbW9uL3VuaWNvZGUvY2F0ZWdvcnlfdGVzdC5j CkBAIC01NCw3ICs1NCw3IEBAIHBhcnNlX3VuaWNvZGVfdmVyc2lvbihjb25zdCBjaGFyICp2ZXJz aW9uKQogICogV2hpdGVfU3BhY2UsIGFuZCBIZXhfRGlnaXQuCiAgKi8KIHN0YXRpYyB2b2lkCi1p Y3VfdGVzdCgpCitpY3VfdGVzdCh2b2lkKQogewogCWludAkJCXN1Y2Nlc3NmdWwgPSAwOwogCWlu dAkJCXBnX3NraXBwZWRfY29kZXBvaW50cyA9IDA7Ci0tIAoyLjQzLjAKCg== --=-Lb2wDrzrRvFxln6PhoJb Content-Disposition: attachment; filename="v1-0002-Fix-callers-of-unicode_strtitle-using-srclen-1.patch" Content-Type: text/x-patch; name="v1-0002-Fix-callers-of-unicode_strtitle-using-srclen-1.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSBiMTA0YzY0ZTU1NzJiMDQ2MjJjMTE4ODNkMmE4MmU1NzlkMTM0OTQ0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIERhdmlzIDxqZWZmQGotZGF2aXMuY29tPgpEYXRlOiBU aHUsIDE2IEFwciAyMDI2IDE2OjIwOjAyIC0wNzAwClN1YmplY3Q6IFtQQVRDSCB2MSAyLzJdIEZp eCBjYWxsZXJzIG9mIHVuaWNvZGVfc3RydGl0bGUoKSB1c2luZyBzcmNsZW4gPT0gLTEuCgpDdXJy ZW50bHksIG9ubHkgY2FsbGVkIHRoYXQgd2F5IGluIHRlc3RzLCB3aGljaCBmYWlsZWQgdG8gZmFp bC4KCkJhY2twYXRjaC10aHJvdWdoOiAxOAotLS0KIHNyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ19s b2NhbGVfYnVpbHRpbi5jIHwgMiArLQogc3JjL2NvbW1vbi91bmljb2RlL2Nhc2VfdGVzdC5jICAg ICAgICAgICAgfCAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC91dGlscy9hZHQvcGdfbG9jYWxlX2J1 aWx0aW4uYyBiL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ19sb2NhbGVfYnVpbHRpbi5jCmluZGV4 IGI1YWViN2EzMzdhLi43OTRhYTM3ZGY3NiAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvdXRpbHMv YWR0L3BnX2xvY2FsZV9idWlsdGluLmMKKysrIGIvc3JjL2JhY2tlbmQvdXRpbHMvYWR0L3BnX2xv Y2FsZV9idWlsdGluLmMKQEAgLTk3LDcgKzk3LDcgQEAgc3RydGl0bGVfYnVpbHRpbihjaGFyICpk ZXN0LCBzaXplX3QgZGVzdHNpemUsIGNvbnN0IGNoYXIgKnNyYywgc3NpemVfdCBzcmNsZW4sCiB7 CiAJc3RydWN0IFdvcmRCb3VuZGFyeVN0YXRlIHdic3RhdGUgPSB7CiAJCS5zdHIgPSBzcmMsCi0J CS5sZW4gPSBzcmNsZW4sCisJCS5sZW4gPSAoc3JjbGVuIDwgMCkgPyBzdHJsZW4oc3JjKSA6IHNy Y2xlbiwKIAkJLm9mZnNldCA9IDAsCiAJCS5wb3NpeCA9ICFsb2NhbGUtPmJ1aWx0aW4uY2FzZW1h cF9mdWxsLAogCQkuaW5pdCA9IGZhbHNlLApkaWZmIC0tZ2l0IGEvc3JjL2NvbW1vbi91bmljb2Rl L2Nhc2VfdGVzdC5jIGIvc3JjL2NvbW1vbi91bmljb2RlL2Nhc2VfdGVzdC5jCmluZGV4IGUzNGY3 MDBkOWM0Li4wOTk1MzBjMWVhZCAxMDA2NDQKLS0tIGEvc3JjL2NvbW1vbi91bmljb2RlL2Nhc2Vf dGVzdC5jCisrKyBiL3NyYy9jb21tb24vdW5pY29kZS9jYXNlX3Rlc3QuYwpAQCAtMzA0LDcgKzMw NCw3IEBAIHRmdW5jX3RpdGxlKGNoYXIgKmRzdCwgc2l6ZV90IGRzdHNpemUsIGNvbnN0IGNoYXIg KnNyYywKIHsKIAlzdHJ1Y3QgV29yZEJvdW5kYXJ5U3RhdGUgd2JzdGF0ZSA9IHsKIAkJLnN0ciA9 IHNyYywKLQkJLmxlbiA9IHNyY2xlbiwKKwkJLmxlbiA9IChzcmNsZW4gPCAwKSA/IHN0cmxlbihz cmMpIDogc3JjbGVuLAogCQkub2Zmc2V0ID0gMCwKIAkJLmluaXQgPSBmYWxzZSwKIAkJLnByZXZf YWxudW0gPSBmYWxzZSwKLS0gCjIuNDMuMAoK --=-Lb2wDrzrRvFxln6PhoJb--