From: Ronan Dunklau <ronan.dunklau@aiven.io>
To: Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org,
 Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: Converting contrib SQL functions to new style
Date: Wed, 06 Nov 2024 10:51:29 +0100
Message-ID: <5829980.DvuYhMxLoT@aivenlaptop>
In-Reply-To: <ZysEEDZqsnP7GTKA@paquier.xyz>
References: 
 <3395418.1618352794@sss.pgh.pa.us> <3133933.1730855116@sss.pgh.pa.us>
 <ZysEEDZqsnP7GTKA@paquier.xyz>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Archived-At: 
 <https://www.postgresql.org/message-id/5829980.DvuYhMxLoT%40aivenlaptop>
Precedence: bulk

Le mercredi 6 novembre 2024, 06:52:16 heure normale d=E2=80=99Europe centra=
le Michael=20
Paquier a =C3=A9crit :
> On Tue, Nov 05, 2024 at 08:05:16PM -0500, Tom Lane wrote:
> > No, I don't think so.  For one thing, it would not help existing
> > installations unless they issue "ALTER EXTENSION UPDATE", which
> > people are not likely to do in a minor update.  But also, we don't
> > know of live attacks against these functions with their current
> > definitions, so I don't think this is urgent.
>=20
> OK, thanks.

=46or most of them I agree, but one side effect of the current implementati=
on is=20
that we have a bug when pg_upgrad'ing if earthdistance is installed:=20
https://www.postgresql.org/message-id/flat/
152106914669.1223.5104148605998271987%40wrigleys.postgresql.org

The new version of earthdistance fixes that problem, so this one would be w=
orth=20
a back patch to 16, giving users the opportunity to update earthdistance=20
before running pg_upgrade.

Thanks for the tip about the CI, will make sure to have it setup before nex=
t=20
time.

=2D-
Ronan Dunklau