Content-Type: multipart/alternative;
 boundary="------------DjB0V0CcCtjmu19jIQsVka6v"
Message-ID: <582c503b-cd98-1891-ff87-9c8e8ce73ee5@dunslane.net>
Date: Sat, 22 Apr 2023 07:42:36 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: run pgindent on a regular basis / scripted manner
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>, Jelte Fennema <postgres@jeltef.nl>
Cc: "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
 Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
 Justin Pryzby <pryzby@telsasoft.com>, Andres Freund <andres@anarazel.de>,
 Noah Misch <noah@leadboat.com>, Peter Geoghegan <pg@bowt.ie>,
 Bruce Momjian <bruce@momjian.us>, Magnus Hagander <magnus@hagander.net>,
 Alvaro Herrera <alvherre@2ndquadrant.com>, Stephen Frost
 <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 Peter Eisentraut <peter.eisentraut@enterprisedb.com>
References: <3d67bc80-4de2-5ba8-e272-e4ad2e59ba04@dunslane.net>
 <4ac8f263-f1bb-faa5-a307-1fffe00f0e3e@dunslane.net>
 <CAGECzQRJrcoxozHh=BRTdLrirFui-3nvdRZru7GGa4F9HJV2Rw@mail.gmail.com>
 <b8f18576-afc0-d961-b33b-c0fa2e63edeb@dunslane.net>
 <0f074818-b01a-799f-3c74-5fb5deab1d23@dunslane.net>
 <CAGECzQSUYmfTwEWcVfwb4d=vf=M7RYJjq6ie0YPTUhP+YFcEww@mail.gmail.com>
 <1d66447e-a77b-ca0d-90a0-782800e85383@dunslane.net>
 <OSZPR01MB63100E1C06045FB66B16728BFDA09@OSZPR01MB6310.jpnprd01.prod.outlook.com>
 <e89d122e-6cf6-d0dc-8fe9-1dfa1de8dcab@dunslane.net>
 <CAGECzQSu6mLzPhd7csBfnXtW9kfoVRn5TWFH1fPGMc4mpkHyOw@mail.gmail.com>
 <ZEOfzsDrQ1SMOj4Q@paquier.xyz>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <ZEOfzsDrQ1SMOj4Q@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/582c503b-cd98-1891-ff87-9c8e8ce73ee5%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------DjB0V0CcCtjmu19jIQsVka6v
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2023-04-22 Sa 04:50, Michael Paquier wrote:
> On Fri, Apr 21, 2023 at 09:58:17AM +0200, Jelte Fennema wrote:
>> For 2 the upstream thread listed two approaches:
>> a. Install a pre-receive git hook on the git server that rejects
>> pushes to master that are not indented
>> b. Add a test suite that checks if the code is correctly indented, so
>> the build farm would complain about it. (Suggested by Peter E)
>>
>> I think both a and b would work to achieve 2. But as Peter E said, b
>> indeed sounds like less of a divergence of the status quo. So my vote
>> would be for b.
> FWIW, I think that there is value for both of them.  Anyway, isn't 'a'
> exactly the same as 'b' in design?  Both require a build of
> pg_bsd_indent, meaning that 'a' would also need to run an equivalent
> of the regression test suite, but it would be actually costly
> especially if pg_bsd_indent itself is patched.  I think that getting
> more noisy on this matter with 'b' would be enough, but as an extra
> PG_TEST_EXTRA for committers to set.
>
> Such a test suite would need a dependency to the 'git' command itself,
> which is not something that could be safely run in a release tarball,
> in any case.


Perhaps we should start with a buildfarm module, which would run 
pg_indent --show-diff. That would only need to run on one animal, so a 
failure wouldn't send the whole buildfarm red. This would be pretty easy 
to do.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------DjB0V0CcCtjmu19jIQsVka6v
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 2023-04-22 Sa 04:50, Michael Paquier
      wrote:<br>
    </div>
    <blockquote type="cite" cite="mid:ZEOfzsDrQ1SMOj4Q@paquier.xyz">
      <pre class="moz-quote-pre" wrap="">On Fri, Apr 21, 2023 at 09:58:17AM +0200, Jelte Fennema wrote:
</pre>
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">For 2 the upstream thread listed two approaches:
a. Install a pre-receive git hook on the git server that rejects
pushes to master that are not indented
b. Add a test suite that checks if the code is correctly indented, so
the build farm would complain about it. (Suggested by Peter E)

I think both a and b would work to achieve 2. But as Peter E said, b
indeed sounds like less of a divergence of the status quo. So my vote
would be for b.
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
FWIW, I think that there is value for both of them.  Anyway, isn't 'a'
exactly the same as 'b' in design?  Both require a build of
pg_bsd_indent, meaning that 'a' would also need to run an equivalent
of the regression test suite, but it would be actually costly
especially if pg_bsd_indent itself is patched.  I think that getting
more noisy on this matter with 'b' would be enough, but as an extra
PG_TEST_EXTRA for committers to set.

Such a test suite would need a dependency to the 'git' command itself,
which is not something that could be safely run in a release tarball,
in any case.
</pre>
    </blockquote>
    <p><br>
    </p>
    <p>Perhaps we should start with a buildfarm module, which would run
      pg_indent --show-diff. That would only need to run on one animal,
      so a failure wouldn't send the whole buildfarm red. This would be
      pretty easy to do.<br>
    </p>
    <p><br>
    </p>
    <p>cheers</p>
    <p><br>
    </p>
    <p>andrew<br>
    </p>
    <p>
    </p>
    <pre class="moz-signature" signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------DjB0V0CcCtjmu19jIQsVka6v--