Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ltIS1-0002z0-7G for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Jun 2021 23:26:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ltIRy-0007Wp-Kd for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Jun 2021 23:26:30 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ltIRy-0007Wh-8p for pgsql-hackers@lists.postgresql.org; Tue, 15 Jun 2021 23:26:30 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ltIRw-0000HM-92 for pgsql-hackers@lists.postgresql.org; Tue, 15 Jun 2021 23:26:29 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 15FNQPs5583675; Tue, 15 Jun 2021 19:26:25 -0400 From: Tom Lane To: Alvaro Herrera cc: pgsql-hackers@lists.postgresql.org Subject: Re: Improving isolationtester's data output In-reply-to: <202106152320.xfiprkh4sp5c@alvherre.pgsql> References: <202106152320.xfiprkh4sp5c@alvherre.pgsql> Comments: In-reply-to Alvaro Herrera message dated "Tue, 15 Jun 2021 19:20:11 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <583673.1623799585.1@sss.pgh.pa.us> Date: Tue, 15 Jun 2021 19:26:25 -0400 Message-ID: <583674.1623799585@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Alvaro Herrera writes: > On 2021-Jun-15, Tom Lane wrote: >> If we wanted to buy into that, I'd think about discarding this >> ad-hoc code altogether in favor of using one of libpq's fe-print.c >> routines. But I'm not really sure that the small legibility gains >> that would result are worth massive changes in the output files. > Shrug -- it's a one time change. It wouldn't bother me, for one. Going forward it wouldn't be a problem, but back-patching isolation test cases might find it annoying. On the other hand, my nearby patch to improve isolation test stability is already going to create issues of that sort. (Unless, dare I say it, we back-patch that.) I do find it a bit attractive to create some regression-testing coverage of fe-print.c. We are never going to remove that code, AFAICS, so getting some benefit from it would be nice. regards, tom lane