Message-ID: <5845262d-9b6a-71f7-3485-c06e4977586f@postgrespro.ru>
Date: Wed, 11 Oct 2023 13:09:36 +0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: Problem, partition pruning for prepared statement with IS NULL
 clause.
Content-Language: en-US
To: David Rowley <dgrowleyml@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
References: <d05b26fa-af54-27e1-f693-6c31590802fa@postgrespro.ru>
 <CAApHDvrc8BjkN8U3NUVzvat3EtC7bzLwFdUw_OFf3Sv-QCp-Vg@mail.gmail.com>
 <2f09ce72-315e-2a33-589a-8519ada8df61@postgrespro.ru>
 <CAApHDvq2gjyqkn=h95kFqRrTKUorrb9ab0bMoQnEua-v6p5Pcw@mail.gmail.com>
 <CAApHDvpf2VU4JHEBfXJsHF1Aq=+aKbtfKx3dtsZudOKLF2wu7Q@mail.gmail.com>
From: Sergei Glukhov <s.glukhov@postgrespro.ru>
In-Reply-To: 
 <CAApHDvpf2VU4JHEBfXJsHF1Aq=+aKbtfKx3dtsZudOKLF2wu7Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/5845262d-9b6a-71f7-3485-c06e4977586f%40postgrespro.ru>
Precedence: bulk

Hi,

Thanks for fixing this!

I verified that issues are fixed.

On 10/11/23 11:50, David Rowley wrote:

> I'm aiming to commit these as two separate fixes, so I'm going to go
> look again at the first one and wait to see if anyone wants to comment
> on this patch in the meantime.

Regarding test case for the first patch,
the line 'set plan_cache_mode = 'force_generic_plan';' is not necessary
since cache mode is set at the top of the test. On the other hand test
scenario can silently  be loosed if someone set another cache mode
somewhere upper. As you mentioned earlier it's worth maybe adding
the test for run-time partition pruning.

Regards,
Gluh