From: Tom Lane <tgl@sss.pgh.pa.us>
To: Corey Huinker <corey.huinker@gmail.com>
cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org,
        Nikita Glukhov <n.gluhov@postgrespro.ru>,
        Andrew Dunstan <andrew@dunslane.net>,
        David Rowley <dgrowleyml@gmail.com>
Subject: Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep
 size
In-reply-to: 
 <CADkLM=c7ya93KcFxAuDp08Ngbyn5n90BHsf=E+5_2EGCubzqsQ@mail.gmail.com>
References: <20220616233130.rparivafipt6doj3@alap3.anarazel.de>
 <1014296.1655422634@sss.pgh.pa.us> <295606.1677101684@sss.pgh.pa.us>
 <20230222224713.m65d55udzlq5mpbz@awork3.anarazel.de>
 <CADkLM=c7ya93KcFxAuDp08Ngbyn5n90BHsf=E+5_2EGCubzqsQ@mail.gmail.com>
Comments: In-reply-to Corey Huinker <corey.huinker@gmail.com>
	message dated "Thu, 23 Feb 2023 13:39:14 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <587320.1677178616.1@sss.pgh.pa.us>
Date: Thu, 23 Feb 2023 13:56:56 -0500
Message-ID: <587321.1677178616@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/587321.1677178616%40sss.pgh.pa.us>
Precedence: bulk

Corey Huinker <corey.huinker@gmail.com> writes:
> My not-ready-for-16 work on CAST( ... ON DEFAULT ... ) involved making
> FuncExpr/IoCoerceExpr/ArrayCoerceExpr have a safe_mode flag, and that
> necessitates adding a reserror boolean to ExprEvalStep for subsequent steps
> to test if the error happened.

Why do you want it in ExprEvalStep ... couldn't it be in ExprState?
I can't see why you'd need more than one at a time during evaluation.

			regards, tom lane