Feedback-ID: ie0a040ee:Fastmail
Message-ID: <5891d1c8-d1cc-4dd1-9e4e-744708f791c7@eisentraut.org>
Date: Wed, 15 Oct 2025 20:15:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: AIX support
To: Srirama Kucherlapati <sriram.rk@in.ibm.com>,
 Andres Freund <andres@anarazel.de>,
 AIX PG user <postgres-ibm-aix@wwpdl.vnet.ibm.com>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
References: 
 <CY5PR11MB63928CC05906F27FB10D74D0FD322@CY5PR11MB6392.namprd11.prod.outlook.com>
 <ko5nio3iyt7fonvwqqgs6gddzyzlad7qm5v6zo72h753jmitwy@llz3bghejzig>
 <175863756865.1038.1316404745203068811.pgcf@coridan.postgresql.org>
 <3xsqvatpnbb7wd3vdxdygzh6s2bbxn3ulmarli67x5u7hekvei@3it2vxprjglu>
 <SJ4PPFB817783263D506AAE4C480F5B2866DB1DA@SJ4PPFB81778326.namprd15.prod.outlook.com>
 <SJ4PPFB8177832600E5AAE4214587DC3F7BDBE8A@SJ4PPFB81778326.namprd15.prod.outlook.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <SJ4PPFB8177832600E5AAE4214587DC3F7BDBE8A@SJ4PPFB81778326.namprd15.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/5891d1c8-d1cc-4dd1-9e4e-744708f791c7%40eisentraut.org>
Precedence: bulk

On 15.10.25 17:58, Srirama Kucherlapati wrote:
> Main AIX changes patch - 0001-Changes-to-add-support-for- 
> AIX.v9.pg19.patch (previously submitted one)
> 
> Meson AIX changes patch - 0001-AIX-changes-for-meson-build.patch
> 
> Looking forward to hearing your thoughts on these changes.
> 
> Your feedback on these updates is highly valued.

The largest problem I see in this patch set is that you are making 
unexplained changes in src/include/storage/s_lock.h.  The code that you 
are changing does not only affect AIX but also PPC with other operating 
systems.  AFAICT, the change you are proposing does not correspond to 
the commit that removed AIX support.

Maybe the proposed changes are beneficial for other operating systems as 
well.  But in that case, propose this as a separate patch in a separate 
thread, with supporting information (and probably benchmarks in this case).

If not, then you need to find a way to make this work on AIX without 
materially changing the code that exists for already-supported operating 
systems.