From: Nikolay Shaplov <dhyan@nataraj.su>
To: Yura Sokolov <y.sokolov@postgrespro.ru>,
 pgsql-hackers@lists.postgresql.org, Michael Paquier <michael@paquier.xyz>
Subject: Re: [PATCH] New [relation] option engine
Date: Fri, 08 Dec 2023 15:49:31 +0300
Message-ID: <5892085.MhkbZ0Pkbq@thinkpad-pgpro>
Organization: Postgres Professional
In-Reply-To: <ZXKwzXIkocQbz2Jc@paquier.xyz>
References:
 <CALDaNm0OHMJSD=3RcB4Uvm8h-gEg+rrvj=A-g9_1XAbyKjG9RA@mail.gmail.com>
 <61ac1e3b-4f85-4bd5-b2fa-80cc7e864755@postgrespro.ru>
 <ZXKwzXIkocQbz2Jc@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart1777481.VLH7GnMWUR";
 micalg="pgp-sha512"; protocol="application/pgp-signature"
Archived-At: <https://www.postgresql.org/message-id/5892085.MhkbZ0Pkbq%40thinkpad-pgpro>
Precedence: bulk

--nextPart1777481.VLH7GnMWUR
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"; protected-headers="v1"
From: Nikolay Shaplov <dhyan@nataraj.su>
Subject: Re: [PATCH] New [relation] option engine
Date: Fri, 08 Dec 2023 15:49:31 +0300
Message-ID: <5892085.MhkbZ0Pkbq@thinkpad-pgpro>
Organization: Postgres Professional
In-Reply-To: <ZXKwzXIkocQbz2Jc@paquier.xyz>
MIME-Version: 1.0

=D0=92 =D0=BF=D0=B8=D1=81=D1=8C=D0=BC=D0=B5 =D0=BE=D1=82 =D0=BF=D1=8F=D1=82=
=D0=BD=D0=B8=D1=86=D0=B0, 8 =D0=B4=D0=B5=D0=BA=D0=B0=D0=B1=D1=80=D1=8F 2023=
 =D0=B3. 08:59:41 MSK =D0=BF=D0=BE=D0=BB=D1=8C=D0=B7=D0=BE=D0=B2=D0=B0=D1=
=82=D0=B5=D0=BB=D1=8C Michael=20
Paquier =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB:

> > I've rebased patch, so it could be add to commitfest again.
>=20
> This is a 270kB patch with quite a few changes, and a lot of code
>=20
> moved around:
> >  47 files changed, 2592 insertions(+), 2326 deletions(-)
>=20
> Could it be possible to split that into more successive steps to ease
> its review?

Theoretically I can create patch with full options.c as it is in the patch=
=20
now, and use that code only in index AM, and keep reloption.c mostly=20
unchanged.

This will be total mess with two different options mechanisms working in th=
e=20
same time, but this might be much more easy to review.  When we are done wi=
th=20
the first step, we can change the rest.
If this will help to finally include patch into postgres, I can do it. Will=
=20
that help you to review?


=2D-=20
Nikolay Shaplov aka Nataraj
=46uzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su

--nextPart1777481.VLH7GnMWUR
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEE+sk3ebqQKlezKOi8PMbfuIHAGpgFAmVzENsACgkQPMbfuIHA
GpichwgAglqWsr8g5V0wbDJmR8GeICXBi8j2uhpOOUmijsZceNJhAJ3xZLZ8vwT5
zScvekccqFqjNe5zyFOXtrX8BqZjfRBLMkiY6+wG4R1CrHivOgSzYfqTD3gXFDeF
PB/emLyN51SO2cqNHvbg6O0LLC4OXEU4bWb6m8odMImbvmTT5m2jft2uBo17e7p5
fFrgCEem6d9vv8NoY3+3azHuxeCfRuxWqnfVUFpOSM/g+3S7xjtn35uzJCeVgEgY
DmosRxdauIPpFylV4m/9T8X9sw0LMCZZHv3T6yVIOaRtqppGIG56zK392rjWV8QZ
oof6WmWUUPUEE2B91tJ6VFqecrMERw==
=uwYK
-----END PGP SIGNATURE-----

--nextPart1777481.VLH7GnMWUR--