Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1sRA2R-00DcgR-DB
	for pgsql-hackers@arkaria.postgresql.org; Tue, 09 Jul 2024 12:33:43 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1sRA2P-00FLve-Sm
	for pgsql-hackers@arkaria.postgresql.org; Tue, 09 Jul 2024 12:33:41 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1sRA2P-00FLvW-J6
	for pgsql-hackers@lists.postgresql.org; Tue, 09 Jul 2024 12:33:41 +0000
Received: from oss.nttdata.com ([49.212.34.109])
	by magus.postgresql.org with esmtps  (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1sRA2M-001DeQ-Gi
	for pgsql-hackers@postgresql.org; Tue, 09 Jul 2024 12:33:40 +0000
Received: from [192.168.11.2] (p3952216-ipxg13501funabasi.chiba.ocn.ne.jp
 [122.16.205.216])
	by oss.nttdata.com (Postfix) with ESMTPSA id A93CE619B4;
	Tue,  9 Jul 2024 21:33:33 +0900 (JST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.11 at oss.nttdata.com
Message-ID: <5899b3bf-8a34-46bb-ae75-6847828bb942@oss.nttdata.com>
Date: Tue, 9 Jul 2024 21:33:33 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: doc: modify the comment in function libpqrcv_check_conninfo()
To: ikedarintarof <ikedarintarof@oss.nttdata.com>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>,
 Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
References: <6a1ca81b27fec4da0ccdfaaaec787982@oss.nttdata.com>
 <CAGECzQRjJkCQ9AUQA_7kJw8c4iUwVAXPfD_VQu+-DVcd-LCT8A@mail.gmail.com>
 <9c15a4b74d09348d03b02934fc429c94@oss.nttdata.com>
 <CAGECzQQ+bpYVuF6GpVdc9vzHOObs5HJLmj5YohOb2d-ctmCffg@mail.gmail.com>
 <c380192faada009af9aa5bfcd06e140d@oss.nttdata.com>
 <CAGECzQRPygEJr3Ed2p7QsUsBkecUa0mpiE3zMOEh5_NtvAfgRw@mail.gmail.com>
 <202ec279-c307-48b9-9920-730fb1221d27@oss.nttdata.com>
 <d5f5fb21f27c17c400a4dbe386d008a8@oss.nttdata.com>
 <2faf37e9-3941-43b5-93e8-f54965b250df@oss.nttdata.com>
 <7d845121f0ea99e68b4403b9cd6f86ac@oss.nttdata.com>
Content-Language: en-US
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <7d845121f0ea99e68b4403b9cd6f86ac@oss.nttdata.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/5899b3bf-8a34-46bb-ae75-6847828bb942%40oss.nttdata.com>
Precedence: bulk



On 2024/07/09 15:56, ikedarintarof wrote:
>> - * Validate connection info string, and determine whether it might cause
>> - * local filesystem access to be attempted.
>> + * The function
>> + * 1. validates connection info string and
>> + * 2. checks a password is provided if must_use_password is true.
>>
>> IMO, "Validate connection info string" is sufficient. The mention of
>> must_use_password is redundant since it's explained in the latter part of
>> the comment.
> 
> That is reasonable for me. I've removed the second one.
> The modified patch is attached.

Thanks for updating the patch! Pushed.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION