Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cwLGs-0006QN-KO for pgsql-hackers@arkaria.postgresql.org; Fri, 07 Apr 2017 04:13:14 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cwLGs-0003ph-75 for pgsql-hackers@arkaria.postgresql.org; Fri, 07 Apr 2017 04:13:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cwLGp-0003YJ-JO for pgsql-hackers@postgresql.org; Fri, 07 Apr 2017 04:13:11 +0000 Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]) by magus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cwLGm-0002u2-Ua for pgsql-hackers@postgresql.org; Fri, 07 Apr 2017 04:13:11 +0000 Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id v374D7C4014364 for ; Fri, 7 Apr 2017 13:13:07 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 391AE5F63F for ; Fri, 7 Apr 2017 13:13:07 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 2D31F5F631 for ; Fri, 7 Apr 2017 13:13:07 +0900 (JST) Received: from [127.0.0.1] (unknown [129.60.241.68]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 02D89400355 for ; Fri, 7 Apr 2017 13:13:07 +0900 (JST) Message-ID: <58E711AF.7070305@lab.ntt.co.jp> Date: Fri, 07 Apr 2017 13:12:31 +0900 From: Tatsuro Yamada User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 Subject: Minor code improvement to postgresGetForeignPlan Content-Type: multipart/mixed; boundary="------------050901000206080109030302" To: pgsql-hackers@postgresql.org X-TM-AS-MML: disable X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org This is a multi-part message in MIME format. --------------050901000206080109030302 Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Hi, The declaration of postgresGetForeignPlan uses baserel, but the actual definition uses foreignrel. It would be better to sync. Please find attached a patch. Tatsuro Yamada NTT Open Source Software Center --------------050901000206080109030302 Content-Type: text/x-patch; name="fix_declaration_of_postgresGetForeignPlan.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fix_declaration_of_postgresGetForeignPlan.patch" diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c index 2851869..54edf4d 100644 --- a/contrib/postgres_fdw/postgres_fdw.c +++ b/contrib/postgres_fdw/postgres_fdw.c @@ -280,7 +280,7 @@ static void postgresGetForeignPaths(PlannerInfo *root, RelOptInfo *baserel, Oid foreigntableid); static ForeignScan *postgresGetForeignPlan(PlannerInfo *root, - RelOptInfo *baserel, + RelOptInfo *foreignrel, Oid foreigntableid, ForeignPath *best_path, List *tlist, --------------050901000206080109030302 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------050901000206080109030302--