public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andrew Dunstan <[email protected]>
To: Tom Lane <[email protected]>
To: Alexander Korotkov <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: pgsql: psql: add an optional execution-count limit to \watch.
Date: Sat, 27 Apr 2024 08:15:36 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAPpHfdv+10Uk6FWjsh3+ju7kHYr76LaRXbYayXmrM7FBU-=Hgg@mail.gmail.com>
	<[email protected]>


On 2023-04-07 Fr 10:00, Tom Lane wrote:
> Alexander Korotkov<[email protected]>  writes:
>> On Thu, Apr 6, 2023 at 8:18 PM Tom Lane<[email protected]>  wrote:
>>> psql: add an optional execution-count limit to \watch.
>> This commit makes tests fail for me.  psql parses 'i' option of
>> '\watch' using locale-aware strtod(), but 001_basic.pl uses hard-coded
>> decimal separator.
> Huh, yeah, I see it too if I set LANG=ru_RU.utf8 before running psql's
> TAP tests.  It seems unfortunate that none of the buildfarm has noticed
> this.  I guess all the TAP tests are run under C locale?


[just noticed this, redirecting to -hackers]


When run under meson, yes unless the LANG/LC_* settings are explicitly 
in the build_env. I'm fixing that so we will allow them to pass through. 
When run with configure/make they run with whatever is in the calling 
environment unless overridden in the build_env.

We do have support for running installchecks with multiple locales.This 
is done by passing --locale=foo to initdb.

We could locale-enable the non-install checks (for meson builds, that's 
the 'misc-check' step, for configure/make builds it's more or less 
everything between the install stages and the (first) initdb step. We'd 
have to do that via appropriate environment settings, I guess. Would it 
be enough to set LANG, or do we need to set the LC_foo settings 
individually? Not sure how we manage it on Windows. Maybe just not 
enable it for the first go-round.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgsql: psql: add an optional execution-count limit to \watch.
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox