Message-ID: <5918e2f0-bb2c-f652-4ec0-982c82fcb0ff@postgresfriends.org>
Date: Tue, 15 Aug 2023 07:58:17 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] Add function to_oct
Content-Language: en-US
To: Nathan Bossart <nathandbossart@gmail.com>, Kirk Wolak <wolakk@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
 Eric Radman <ericshane@eradman.com>, pgsql-hackers@postgresql.org
References: <Y6IyTQQ/TsD5wnsH@vm3.eradman.com>
 <5c260f97-d8c8-4a68-7498-022e550c6b10@enterprisedb.com>
 <CACLU5mQ9BGiMaTbS+EpvxngdEf35aX+Tcs31K8UJMkbxaZh5JA@mail.gmail.com>
 <20230725232426.GA2992317@nathanxps13> <20230726001656.GC2992317@nathanxps13>
 <20230726032917.GA3151386@nathanxps13> <20230815041129.GB2294364@nathanxps13>
From: Vik Fearing <vik@postgresfriends.org>
In-Reply-To: <20230815041129.GB2294364@nathanxps13>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/5918e2f0-bb2c-f652-4ec0-982c82fcb0ff%40postgresfriends.org>
Precedence: bulk

On 8/15/23 06:11, Nathan Bossart wrote:
> On Tue, Jul 25, 2023 at 08:29:17PM -0700, Nathan Bossart wrote:
>> Here's a new version of the patch with the silly mistakes fixed.
> 
> If there are no objections, I'd like to commit this patch soon.

I just took a look at this (and the rest of the thread).  I am a little 
bit disappointed that we don't have a generic base conversion function, 
but even if we did I think these specialized functions would still be 
useful.

No objection from me.
-- 
Vik Fearing