From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Ning <ning94803@gmail.com>, pgsql-hackers@lists.postgresql.org,
        Andrew Dunstan <andrew@dunslane.net>
Subject: Re: psql client does not handle WSAEWOULDBLOCK on Windows
In-reply-to: <Z1fifjpgDAxPPkuh@paquier.xyz>
References: 
 <CAFGqpvg-pRw=cdsUpKYfwY6D3d-m9tw8WMcAEE7HHWfm-oYWvw@mail.gmail.com>
 <CAFGqpvgJ_Y-POTgogbmzxTbUXrci3gLqcasw1rAZ4y2Wh+9+nA@mail.gmail.com>
 <Z1fifjpgDAxPPkuh@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Tue, 10 Dec 2024 15:41:02 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <592100.1756828301.1@sss.pgh.pa.us>
Date: Tue, 02 Sep 2025 11:51:41 -0400
Message-ID: <592101.1756828301@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/592101.1756828301%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> This is going to require some platform-specific check that I don't
> have with me, though I am ready to accept that what you are telling
> here is true and that we should apply this macro.  Could somebody
> check that a bit more in depth?  Andrew D. perhaps?

> One thing that I don't understand is why does this only apply after
> the first call of pqsecure_raw_read() in gss_read()?  There is a
> second call of pqsecure_raw_read() you are not covering but it would
> surely need the same treatment, no?

> Also, what about pqsecure_raw_write() in pqsecure_open_gss()?
> Shouldn't the same check apply?

Yeah, I think we pretty much need to use SOCK_ERRNO, SOCK_ERRNO_SET,
and SOCK_STRERROR (if relevant) throughout fe-secure-gssapi.c.
Directly using errno is correct for syscalls related to the file
system, but I think everything in this file is dealing with
socket-related errors.  Certainly the underlying pqsecure_raw_read
and pqsecure_raw_write layer expects those macros to be used.

Like you, I'm not really in a position to test this on Windows ...

			regards, tom lane