To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
From: Chapman Flack <chap@anastigmatix.net>
Subject: [PATCH] quiet conversion warning in DatumGetFloat4
Message-ID: <592E4D04.1070609@anastigmatix.net>
Date: Wed, 31 May 2017 00:56:36 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------040107020401070809020709"
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

This is a multi-part message in MIME format.
--------------040107020401070809020709
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

It seems that 14cca1b (use static inline functions for float <-> Datum
conversions) has an implicit narrowing conversion in one of those
functions.

If building an extension with gcc's -Wconversion warning enabled
(*cough* pljava *cough* ... the Maven plugin that runs the compiler
enables the warning by default), this makes for a noisy build.
The warning is harmless, but repeated everywhere postgres.h is
included. An explicit cast is enough to suppress it.

-Chap

--------------040107020401070809020709
Content-Type: text/x-patch;
 name="quiet-conversion-warning-getfloat4.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="quiet-conversion-warning-getfloat4.patch"

--- src/include/postgres.h	2017-05-15 17:20:59.000000000 -0400
+++ src/include/postgres.h	2017-05-31 00:21:27.329393499 -0400
@@ -679,7 +679,7 @@
 		float4		retval;
 	}			myunion;
 
-	myunion.value = GET_4_BYTES(X);
+	myunion.value = (int32)GET_4_BYTES(X);
 	return myunion.retval;
 }
 #else

--------------040107020401070809020709
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------040107020401070809020709--