Content-Type: multipart/mixed; boundary="------------OHYwaL03VVOhVoj855CXXx02"
Message-ID: <5934ce1e-be02-4640-904c-f7fec3962784@gmail.com>
Date: Mon, 10 Feb 2025 06:19:49 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Removing unneeded self joins
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>,
 Richard Guo <guofenglinux@gmail.com>, Alexander Lakhin
 <exclusion@gmail.com>, "Gregory Stark (as CFM)" <stark.cfm@gmail.com>,
 =?UTF-8?Q?Micha=C5=82_K=C5=82eczek?= <michal@kleczek.org>,
 Dean Rasheed <dean.a.rasheed@gmail.com>
References: <64486b0b-0404-e39e-322d-0801154901f3@postgrespro.ru>
 <CAMbWs49Q8g1LPVCeNHYv-Y-gFo826ertrg6nYNC9LL=8=zHP3g@mail.gmail.com>
 <CAPpHfdsUiwbGLbBwtdL+UCT5GCUVEU+SqQaaZjtcje3znU2JgQ@mail.gmail.com>
 <2422119.1714691974@sss.pgh.pa.us>
 <CAPpHfdv6B8HCLdj8WidBryRrX0+X3F1rrR8uAuMQmp6rvPdscg@mail.gmail.com>
 <24e93efd-eeac-43a6-a75a-ad68eacb32ee@postgrespro.ru>
 <CA+TgmoZ66x=uWasH+O40a=G=fpbXN1ANEdGVunvR8BKuekqa2g@mail.gmail.com>
 <3622801.1715010885@sss.pgh.pa.us>
 <CAPpHfduRB9oW3YRDpvPGcDSAbH4iu0LSRhxpRRAzBh7euC9amQ@mail.gmail.com>
 <CAEZATCUeJ93gWCEzK1eRxyZakvv5PVG9LfF3PkSGMsNBC7h9kA@mail.gmail.com>
 <CAPpHfdsj1WdqoCg+g4oq1XQ_=KOj0U4pXqhauBc7e+0msHu66A@mail.gmail.com>
 <CAPpHfds16a7bjQHv-jCLMNzwdukJ_i3da2e0OJFB9L5rTCWEEg@mail.gmail.com>
 <ac7d7334-7ebb-4330-a894-12ba12ffa4ae@gmail.com>
 <CAPpHfdsuc524-BkXNZ+iz9dH=-KiU8qx9CSyE-Nip4Wjz5pGgg@mail.gmail.com>
 <ac34e44e-f8e1-4601-8bb8-fa5e65578832@gmail.com>
 <CAPpHfdvHzExyROoxvVQz6JR4tGVOjgNyHnu8xJmGcx-bMxWvqw@mail.gmail.com>
Content-Language: en-US
From: Andrei Lepikhov <lepihov@gmail.com>
In-Reply-To: 
 <CAPpHfdvHzExyROoxvVQz6JR4tGVOjgNyHnu8xJmGcx-bMxWvqw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/5934ce1e-be02-4640-904c-f7fec3962784%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------OHYwaL03VVOhVoj855CXXx02
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 9/2/2025 18:41, Alexander Korotkov wrote:
> Regarding adjust_relid_set() and replace_relid().  I think they are
> now strictly equivalent, except for the case then old relid is given
> and not found.  In this case adjust_relid_set() returns the original
> relids while replace_relid() returns a copy.  The behavior of
> adjust_relid_set() appears more desirable as we don't need extra
> copying when no modification is done.  So, I've replaced all
> replace_relid() with adjust_relid_set().
Ok, I glanced into it, and it makes sense to merge these routines.
I think the comment to adjust_relid_set() should be arranged, too. See 
the attachment for a short variant of such modification.
> 
> Also, I did some grammar correction to your new comment in tests.
Thanks!

-- 
regards, Andrei Lepikhov
--------------OHYwaL03VVOhVoj855CXXx02
Content-Type: text/plain; charset=UTF-8; name="comment.diff"
Content-Disposition: attachment; filename="comment.diff"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3Jld3JpdGUvcmV3cml0ZU1hbmlwLmMgYi9zcmMv
YmFja2VuZC9yZXdyaXRlL3Jld3JpdGVNYW5pcC5jCmluZGV4IDZkNTZiNjVhNGIuLjM4YzNl
NGUyMjUgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3Jld3JpdGUvcmV3cml0ZU1hbmlwLmMK
KysrIGIvc3JjL2JhY2tlbmQvcmV3cml0ZS9yZXdyaXRlTWFuaXAuYwpAQCAtNzk0LDEyICs3
OTQsMTAgQEAgQ2hhbmdlVmFyTm9kZXMoTm9kZSAqbm9kZSwgaW50IHJ0X2luZGV4LCBpbnQg
bmV3X2luZGV4LCBpbnQgc3VibGV2ZWxzX3VwKQogfQogCiAvKgotICogU3Vic3RpdHV0ZSBu
ZXdyZWxpZCBmb3Igb2xkcmVsaWQgaW4gYSBSZWxpZCBzZXQKLSAqCisgKiBSZW1vdmUgb2xk
cmVsaWQgZnJvbSBhIFJlbGlkIHNldCBhbmQgcmVwbGFjZSBpdCB3aXRoIG5ld3JlbGlkIGlu
IGNhc2UgaXQgaXMKKyAqIG5vdCBhIHNwZWNpYWwgdmFybm8uCiAgKiBOb3RlOiBzb21lIGV4
dGVuc2lvbnMgbWF5IHBhc3MgYSBzcGVjaWFsIHZhcm5vIHN1Y2ggYXMgSU5ERVhfVkFSIGZv
cgogICogb2xkcmVsaWQuICBibXNfaXNfbWVtYmVyIHdvbid0IGxpa2UgdGhhdCwgYnV0IHdl
IHNob3VsZCB0b2xlcmF0ZSBpdC4KLSAqIChQZXJoYXBzIG5ld3JlbGlkIGNvdWxkIGFsc28g
YmUgYSBzcGVjaWFsIHZhcm5vLCBidXQgdGhlcmUgaGFkIGJldHRlcgotICogbm90IGJlIGEg
cmVhc29uIHRvIGluamVjdCB0aGF0IGludG8gYSBudWxsaW5ncmVscyBvciBwaHJlbHMgc2V0
LikKICAqLwogUmVsaWRzCiBhZGp1c3RfcmVsaWRfc2V0KFJlbGlkcyByZWxpZHMsIGludCBv
bGRyZWxpZCwgaW50IG5ld3JlbGlkKQo=

--------------OHYwaL03VVOhVoj855CXXx02--