Message-ID: <59452d80-0a86-4872-a351-062a057e74f4@iki.fi>
Date: Sun, 5 Apr 2026 21:22:25 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Stack-based tracking of per-node WAL/buffer usage
To: Lukas Fittl <lukas@fittl.com>, Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Zsolt Parragi <zsolt.parragi@percona.com>, Tomas Vondra <tomas@vondra.me>,
 Peter Smith <smithpb2250@gmail.com>
References: 
 <CAP53Pkwdg7Pmf+OqUBu4_SKgxEH3oosSrxxMc4v=mCqMUB049A@mail.gmail.com>
 <CAP53PkyEPa=aFZrd0crLgRJm1KGS0ykJ+1i2CwDfDNFKpCc+XQ@mail.gmail.com>
 <da7ad516-37d1-47e5-afae-26a7ef7b60f8@iki.fi>
 <CAN4CZFOUTHdXuEAwrST8ueDxGJRe69zVgeVAY0osTjVkRZi_Lw@mail.gmail.com>
 <CAP53Pkx+HZ2OSGDHmNgSDisXdjGp4KFygaX+GaQcFEuXHRXg=g@mail.gmail.com>
 <CAP53PkznofNg+ii363QQGoje30nhssuSz_hV5U4YANAt-Yr_Yg@mail.gmail.com>
 <a1edb578-8a54-4f7a-ad74-11ce9cef291a@iki.fi>
 <CAP53PkwCk7X_ryOak_3x6ek2f+4kCgGjWe8aVy39D59Q8y9wTg@mail.gmail.com>
 <CAP53Pky2=31B1AS9vg=Ca9308_hb0H4g968cSKxiFgT0moJfYg@mail.gmail.com>
 <CAP53PkybGzJTAo7V07ssUae5047pBY3jc_F07tGY13cNhqe+AQ@mail.gmail.com>
 <57biou6l65r7gr4nunoe6lignz2x6m3w45gihoypaez4pc46di@txj3bakhj66l>
 <CAP53PkxDupm5U6TV0LF_YWHQ2wfcSiLsgnDBcO6b5AchLJhp=A@mail.gmail.com>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: 
 <CAP53PkxDupm5U6TV0LF_YWHQ2wfcSiLsgnDBcO6b5AchLJhp=A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/59452d80-0a86-4872-a351-062a057e74f4%40iki.fi>
Precedence: bulk

On 05/04/2026 15:31, Lukas Fittl wrote:
> Heikki, your further review is very welcome, if you have the time.
> It'd also be great if you could review the README.instrument (now in
> v13/0008) to see if that makes sense to you.

I don't have very substantial comments to make, an haven't had a chance 
to review the latest patch, but I did read your replies. I think I 
understand the stack vs. tree model now and why it is the way it is, but 
I still find it pretty confusing and I don't know what to about it.

- Heikki