From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Daniel Verite" <daniel@manitou-mail.org>
cc: "Fabien COELHO" <coelho@cri.ensmp.fr>,
        "Robert Haas" <robertmhaas@gmail.com>,
        "Pavel Stehule" <pavel.stehule@gmail.com>,
        "Corey
 Huinker" <corey.huinker@gmail.com>,
        "PostgreSQL Developers" <pgsql-hackers@postgresql.org>
Subject: Re: Variable substitution in psql backtick expansion
In-reply-to: <22a8687d-c192-4bdc-8d4b-053a094d641b@manitou-mail.org>
References: <22a8687d-c192-4bdc-8d4b-053a094d641b@manitou-mail.org>
Comments: In-reply-to "Daniel Verite" <daniel@manitou-mail.org>
	message dated "Mon, 04 Sep 2017 19:14:31 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5955.1504546540.1@sss.pgh.pa.us>
Date: Mon, 04 Sep 2017 13:35:40 -0400
Message-ID: <5956.1504546540@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

"Daniel Verite" <daniel@manitou-mail.org> writes:
> The two-space left margin on the entire block does not add that
> much to readability, IMV, so maybe we could reclaim these
> two characters.

Well, it's a sub-list of the entire output of helpVariables(), so
I think some indentation is a good idea.

> That would look like the following, for example, with a 3-space margin
> for the description:

> AUTOCOMMIT
>    If set, successful SQL commands are automatically committed

But we could do something close to that, say two-space indent for the
variable names and four-space for the descriptions.

> To me that looks like a good trade-off: it eases the size constraints
> for both the description and the name of the variable, at the cost
> of consuming one more line per variable, but that's why the pager
> is for.

Yeah, we're already past the point where it's likely that
helpVariables()'s output would fit on one screen for anybody, so
maybe this is the best way.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers