Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n4O3g-0007IF-ED for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Jan 2022 14:11:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1n4O39-0004Va-I7 for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Jan 2022 14:10:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n4O38-0004VP-Th for pgsql-hackers@lists.postgresql.org; Mon, 03 Jan 2022 14:10:59 +0000 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1n4O33-0003KP-7c for pgsql-hackers@postgresql.org; Mon, 03 Jan 2022 14:10:58 +0000 Received: by mail-qt1-x82c.google.com with SMTP id m25so30432011qtq.13 for ; Mon, 03 Jan 2022 06:10:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=Kyz6J31kitzNy+jZfd6JRhCnZjfAMRxdlFho+y6LbnM=; b=jVWj0O0Z4TGHkmj5KsX9xu8VOOsYdLLaUiILx/AgJWRQ64lxitcxXmd10yqdSP57C+ ARzMhuIors/sQUrRXLu4FAvIlqPM1o9M6RX1FNTCzFvGPy26K5m3a4Llu1OgRA5wUZYi T/3tjjUFLBWKx21b8NudSQJ7ok1aKsu56U3oT6/pdrXvQZf1QEf3gGgGLp6LI/B7CKEF uOgAJTe5VE6Grsaszpp5fo8mm3IlnHldYML294SzBJW+PalfznEwAcVbk2288FSg8oR/ v7lf9EngAVl6Mwly3wJ9kVohmZHg9xYabGJFF/NoWltU/8p+3YUezvU5IKn3PfyMebeY z4sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Kyz6J31kitzNy+jZfd6JRhCnZjfAMRxdlFho+y6LbnM=; b=oqCBtv9JThE5UmYQ0b+3oAQ/n5luSK7iJCDskO4WE1vsekSit+onVAQHIlBdLfVgB7 zC+gxRllptvm0XLQHZsYTFJ8iMxoGuVTjdm+0lBnlZ6vXHtjb1XG3vaMO+iIXO9FIcoe vx5queyXzSZy9vSZOUpSoY3VrrqwjkY2gNGIkdCu7hxRXlTUBr+Gl9du65zf4PgmXirP 6lbJm/pQ8NvV6Uj2s3EbysS1/e9K/43LRXZF/E8Zc+J6Gm130Sp7hJmp+KPqV2uTEld8 trXpf5Tq60WX4QdXBxdsg5Fga+WOajg95Vdw79Lzz67019IGsmQZ9/MHq9stfbLNPfW0 La3g== X-Gm-Message-State: AOAM531x50FwuBWEsx79CG3FziWVuP01slvfX95EDdnDgY9z30G66cKA BgfJNMiNR6SuI4PdK2ybPQjQB98/dSrl8Pcwls9bb5Ai9j9sF3PFFAbNhOvLABgABMBMfwOvFrx 5ReHpHi+500OnE3pBQ59ruecixY/NoX3fq3HdicLKD0kzrmaGeCi/namM7xqTY7erISTiq6NuIA tK/Nuf2aaJWxL5jrasCYnL1QtUeGgKRE0NnVkct85skukBha2tBBuADz5R7A7/WYuvVjnR+NH4I lYBM+mXIzbc8xm81KRw7/q63f36lZ+HbQjMvw== X-Google-Smtp-Source: ABdhPJxE0CnK3ey9ed/3dT8qzLpNRiOUMqFD+lNGUnbLPrA2th3qJNgSGrTZIMnWUEv26EgBnrz7gg== X-Received: by 2002:ac8:5c91:: with SMTP id r17mr41508018qta.18.1641219050725; Mon, 03 Jan 2022 06:10:50 -0800 (PST) Received: from localhost.localdomain ([45.113.251.168]) by smtp.gmail.com with ESMTPSA id j13sm28572136qtr.21.2022.01.03.06.10.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jan 2022 06:10:29 -0800 (PST) Subject: Re: refactoring basebackup.c To: Jeevan Ladhe , Robert Haas Cc: Dmitry Dolgov <9erthalion6@gmail.com>, Mark Dilger , "pgsql-hackers@postgresql.org" References: <20211115162641.dmo6l32fklh64gnw@localhost> From: tushar Message-ID: <595e004f-c2c3-2b74-d4cc-0f1b0d35d42d@enterprisedb.com> Date: Mon, 3 Jan 2022 19:39:58 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 11/22/21 11:05 PM, Jeevan Ladhe wrote: > Please find the lz4 compression patch here that basically has: One small issue, in the "pg_basebackup --help", we are not displaying lz4 value under --server-compression option [edb@tusharcentos7-v14 bin]$ ./pg_basebackup --help | grep server-compression       --server-compression=none|gzip|gzip[1-9] -- regards,tushar EnterpriseDB https://www.enterprisedb.com/ The Enterprise PostgreSQL Company