public inbox for [email protected]  

help / color / mirror / Atom feed

From: Heikki Linnakangas <[email protected]>
To: Ranier Vilela <[email protected]>
Cc: Pg Hackers <[email protected]>
Subject: Re: Fix possible dereference null pointer (src/backend/replication/logical/reorderbuffer.c)
Date: Thu, 11 Apr 2024 15:54:33 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAEudQAp9auHMmBf-jS_-eaE+hQ6dNRJuBJmkGzrMtKndnOCQ9Q@mail.gmail.com>
References: <CAEudQApm0Kffq4GKLdyogyW1tVbkHOOqWTWg169OTsm1W=FUHg@mail.gmail.com>
	<[email protected]>
	<CAEudQAp9auHMmBf-jS_-eaE+hQ6dNRJuBJmkGzrMtKndnOCQ9Q@mail.gmail.com>

On 11/04/2024 15:03, Ranier Vilela wrote:
> Em qua., 10 de abr. de 2024 às 18:28, Heikki Linnakangas 
> <[email protected] <mailto:[email protected]>> escreveu:
> 
>     On 10/04/2024 21:07, Ranier Vilela wrote:
>      > Hi,
>      >
>      > Per Coverity.
>      >
>      > The function ReorderBufferTXNByXid,
>      > can return NULL when the parameter *create* is false.
>      >
>      > In the functions ReorderBufferSetBaseSnapshot
>      > and ReorderBufferXidHasBaseSnapshot,
>      > the second call to ReorderBufferTXNByXid,
>      > pass false to *create* argument.
>      >
>      > In the function ReorderBufferSetBaseSnapshot,
>      > fixed passing true as argument to always return
>      > a valid ReorderBufferTXN pointer.
>      >
>      > In the function ReorderBufferXidHasBaseSnapshot,
>      > fixed by checking if the pointer is NULL.
> 
>     If it's a "known subxid", the top-level XID should already have its
>     ReorderBufferTXN entry, so ReorderBufferTXN() should never return NULL.
> 
> There are several conditions to not return NULL,
> I think trusting never is insecure.

Well, you could make it an elog(ERROR, ..) instead. But the point is 
that it should not happen, and if it does for some reason, that's very 
suprpising and there is a bug somewhere. In that case, we should *not* 
just blindly create it and proceed as if everything was OK.

-- 
Heikki Linnakangas
Neon (https://neon.tech)

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Fix possible dereference null pointer (src/backend/replication/logical/reorderbuffer.c)
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox