Content-Type: multipart/mixed; boundary="------------jiVrVBAc810zvnn1fj7H1AeC"
Message-ID: <597af378-0d0f-0b24-4f82-a5af04863358@gmail.com>
Date: Thu, 28 Dec 2023 22:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: broken master regress tests
Content-Language: en-US
To: Jeff Davis <pgsql@j-davis.com>, Noah Misch <noah@leadboat.com>,
 Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
 Thomas Munro <thomas.munro@gmail.com>,
 Pavel Stehule <pavel.stehule@gmail.com>,
 Matthias van de Meent <boekewurm+postgres@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: 
 <CA+hUKG+VkcevnqLmbZSD4C5hJ3=TQWgMP-th8LqsbNt0TqZfqw@mail.gmail.com>
 <20230829155424.bem25upvaefkqqyy@alvherre.pgsql>
 <20230912022358.d5ln25sglrntwaia@awork3.anarazel.de>
 <0d47e5ecc037b3908149aad5f2a987793cf938bd.camel@j-davis.com>
 <20231011005434.34oc4v4pv6ajqkss@awork3.anarazel.de>
 <20231213025619.70.nmisch@google.com>
 <97c9d15247c5919b444b2e217b4c886271be0ea5.camel@j-davis.com>
 <c6571aac4c6da3e2f013fe74fcc95d6e052bf04c.camel@j-davis.com>
 <ae73f6f5-8221-c112-4640-5cda812a69de@gmail.com>
 <daa2d17d5544e0f75ea05b1024c9feec74b46c12.camel@j-davis.com>
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <daa2d17d5544e0f75ea05b1024c9feec74b46c12.camel@j-davis.com>
Archived-At: 
 <https://www.postgresql.org/message-id/597af378-0d0f-0b24-4f82-a5af04863358%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------jiVrVBAc810zvnn1fj7H1AeC
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

28.12.2023 20:36, Jeff Davis wrote:
> We do want that test to run though, right?

Yes, I think so.

> I suspect that test line never worked reliably. The skip_test check at
> the top guarantees that the collation named "en_US" exists, but that
> doesn't mean that the OS understands the locale 'en_US'.
>
> Perhaps we can change that line to use a similar trick as what's used
> elsewhere in the file:
>
>    do $$
>    BEGIN
>      EXECUTE 'CREATE COLLATION ctest_det (locale = ' ||
>              quote_literal((SELECT collcollate FROM pg_collation WHERE
> collname = ''en_US'')) || ', deterministic = true);';
>    END
>    $$;
>
> The above may need some adjustment, but perhaps you can try it out?

Yes, this trick resolves the issue, it gives locale 'en-US' on that OS,
which works there. Please see the attached patch.

But looking at the result with the comment above that "do" block, I wonder
whether this successful CREATE COLLATION command is so important to perform
it that tricky way, if we want to demonstrate that nondeterministic
collations not supported.
So in case you decide just to remove this command, please see the second
patch.

Best regards,
Alexander
--------------jiVrVBAc810zvnn1fj7H1AeC
Content-Type: text/x-patch; charset=UTF-8;
 name="fix-collate-windows-test-.patch"
Content-Disposition: attachment; filename="fix-collate-windows-test-.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvY29sbGF0ZS53aW5kb3dz
LndpbjEyNTIub3V0IGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9jb2xsYXRlLndpbmRv
d3Mud2luMTI1Mi5vdXQKaW5kZXggYjdiOTM5NTlkZS4uYmI2Mjk3YTExMyAxMDA2NDQKLS0t
IGEvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9jb2xsYXRlLndpbmRvd3Mud2luMTI1Mi5v
dXQKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9jb2xsYXRlLndpbmRvd3Mud2lu
MTI1Mi5vdXQKQEAgLTk5Miw3ICs5OTIsNiBAQCBkcm9wIHR5cGUgdGV4dHJhbmdlX2M7CiBk
cm9wIHR5cGUgdGV4dHJhbmdlX2VuX3VzOwogLS0gbm9uZGV0ZXJtaW5pc3RpYyBjb2xsYXRp
b25zCiAtLSAobm90IHN1cHBvcnRlZCB3aXRoIGxpYmMgcHJvdmlkZXIpCi1DUkVBVEUgQ09M
TEFUSU9OIGN0ZXN0X2RldCAobG9jYWxlID0gJ2VuX1VTJywgZGV0ZXJtaW5pc3RpYyA9IHRy
dWUpOwogQ1JFQVRFIENPTExBVElPTiBjdGVzdF9ub25kZXQgKGxvY2FsZSA9ICdlbl9VUycs
IGRldGVybWluaXN0aWMgPSBmYWxzZSk7CiBFUlJPUjogIG5vbmRldGVybWluaXN0aWMgY29s
bGF0aW9ucyBub3Qgc3VwcG9ydGVkIHdpdGggdGhpcyBwcm92aWRlcgogLS0gY2xlYW51cApk
aWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVncmVzcy9zcWwvY29sbGF0ZS53aW5kb3dzLndpbjEy
NTIuc3FsIGIvc3JjL3Rlc3QvcmVncmVzcy9zcWwvY29sbGF0ZS53aW5kb3dzLndpbjEyNTIu
c3FsCmluZGV4IDM1M2Q3NjlhNWIuLjYyNDZkODk2MzQgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0
L3JlZ3Jlc3Mvc3FsL2NvbGxhdGUud2luZG93cy53aW4xMjUyLnNxbAorKysgYi9zcmMvdGVz
dC9yZWdyZXNzL3NxbC9jb2xsYXRlLndpbmRvd3Mud2luMTI1Mi5zcWwKQEAgLTQwMCw4ICs0
MDAsNiBAQCBkcm9wIHR5cGUgdGV4dHJhbmdlX2VuX3VzOwogCiAtLSBub25kZXRlcm1pbmlz
dGljIGNvbGxhdGlvbnMKIC0tIChub3Qgc3VwcG9ydGVkIHdpdGggbGliYyBwcm92aWRlcikK
LQotQ1JFQVRFIENPTExBVElPTiBjdGVzdF9kZXQgKGxvY2FsZSA9ICdlbl9VUycsIGRldGVy
bWluaXN0aWMgPSB0cnVlKTsKIENSRUFURSBDT0xMQVRJT04gY3Rlc3Rfbm9uZGV0IChsb2Nh
bGUgPSAnZW5fVVMnLCBkZXRlcm1pbmlzdGljID0gZmFsc2UpOwogCiAK
--------------jiVrVBAc810zvnn1fj7H1AeC
Content-Type: text/x-patch; charset=UTF-8;
 name="fix-collate-windows-test+.patch"
Content-Disposition: attachment; filename="fix-collate-windows-test+.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvY29sbGF0ZS53aW5kb3dz
LndpbjEyNTIub3V0IGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9jb2xsYXRlLndpbmRv
d3Mud2luMTI1Mi5vdXQKaW5kZXggYjdiOTM5NTlkZS4uOTdjYmZjODZkZSAxMDA2NDQKLS0t
IGEvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9jb2xsYXRlLndpbmRvd3Mud2luMTI1Mi5v
dXQKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9jb2xsYXRlLndpbmRvd3Mud2lu
MTI1Mi5vdXQKQEAgLTk5Miw3ICs5OTIsMTMgQEAgZHJvcCB0eXBlIHRleHRyYW5nZV9jOwog
ZHJvcCB0eXBlIHRleHRyYW5nZV9lbl91czsKIC0tIG5vbmRldGVybWluaXN0aWMgY29sbGF0
aW9ucwogLS0gKG5vdCBzdXBwb3J0ZWQgd2l0aCBsaWJjIHByb3ZpZGVyKQotQ1JFQVRFIENP
TExBVElPTiBjdGVzdF9kZXQgKGxvY2FsZSA9ICdlbl9VUycsIGRldGVybWluaXN0aWMgPSB0
cnVlKTsKK2RvICQkCitCRUdJTgorICBFWEVDVVRFICdDUkVBVEUgQ09MTEFUSU9OIGN0ZXN0
X2RldCAobG9jYWxlID0gJyB8fAorICAgICAgICAgIHF1b3RlX2xpdGVyYWwoKFNFTEVDVCBj
b2xsY29sbGF0ZSBGUk9NIHBnX2NvbGxhdGlvbiBXSEVSRQorICAgICAgICAgIGNvbGxuYW1l
ID0gJ2VuX1VTJykpIHx8ICcsIGRldGVybWluaXN0aWMgPSB0cnVlKTsnOworICBFTkQKKyQk
OwogQ1JFQVRFIENPTExBVElPTiBjdGVzdF9ub25kZXQgKGxvY2FsZSA9ICdlbl9VUycsIGRl
dGVybWluaXN0aWMgPSBmYWxzZSk7CiBFUlJPUjogIG5vbmRldGVybWluaXN0aWMgY29sbGF0
aW9ucyBub3Qgc3VwcG9ydGVkIHdpdGggdGhpcyBwcm92aWRlcgogLS0gY2xlYW51cApkaWZm
IC0tZ2l0IGEvc3JjL3Rlc3QvcmVncmVzcy9zcWwvY29sbGF0ZS53aW5kb3dzLndpbjEyNTIu
c3FsIGIvc3JjL3Rlc3QvcmVncmVzcy9zcWwvY29sbGF0ZS53aW5kb3dzLndpbjEyNTIuc3Fs
CmluZGV4IDM1M2Q3NjlhNWIuLjcyN2QxMzZmMmYgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L3Jl
Z3Jlc3Mvc3FsL2NvbGxhdGUud2luZG93cy53aW4xMjUyLnNxbAorKysgYi9zcmMvdGVzdC9y
ZWdyZXNzL3NxbC9jb2xsYXRlLndpbmRvd3Mud2luMTI1Mi5zcWwKQEAgLTQwMCw4ICs0MDAs
MTMgQEAgZHJvcCB0eXBlIHRleHRyYW5nZV9lbl91czsKIAogLS0gbm9uZGV0ZXJtaW5pc3Rp
YyBjb2xsYXRpb25zCiAtLSAobm90IHN1cHBvcnRlZCB3aXRoIGxpYmMgcHJvdmlkZXIpCi0K
LUNSRUFURSBDT0xMQVRJT04gY3Rlc3RfZGV0IChsb2NhbGUgPSAnZW5fVVMnLCBkZXRlcm1p
bmlzdGljID0gdHJ1ZSk7CitkbyAkJAorQkVHSU4KKyAgRVhFQ1VURSAnQ1JFQVRFIENPTExB
VElPTiBjdGVzdF9kZXQgKGxvY2FsZSA9ICcgfHwKKyAgICAgICAgICBxdW90ZV9saXRlcmFs
KChTRUxFQ1QgY29sbGNvbGxhdGUgRlJPTSBwZ19jb2xsYXRpb24gV0hFUkUKKyAgICAgICAg
ICBjb2xsbmFtZSA9ICdlbl9VUycpKSB8fCAnLCBkZXRlcm1pbmlzdGljID0gdHJ1ZSk7JzsK
KyAgRU5ECiskJDsKIENSRUFURSBDT0xMQVRJT04gY3Rlc3Rfbm9uZGV0IChsb2NhbGUgPSAn
ZW5fVVMnLCBkZXRlcm1pbmlzdGljID0gZmFsc2UpOwogCiAK

--------------jiVrVBAc810zvnn1fj7H1AeC--