From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
cc: Jeevan Chalke <jeevan.chalke@enterprisedb.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Substantial bloat in postgres_fdw regression test runtime
In-reply-to: 
 <CAFjFpRe2-bbnRDrz4d2dN70JSXvCvVnpn7+8y7hC6Zxr65JbUw@mail.gmail.com>
References: <16565.1478104765@sss.pgh.pa.us>
 <CAM2+6=U72y2_Jni2p+meqTvvk=r_=Wd4orvzz5YL0b3WFx+gcA@mail.gmail.com>
 <CAFjFpRe2-bbnRDrz4d2dN70JSXvCvVnpn7+8y7hC6Zxr65JbUw@mail.gmail.com>
Comments: In-reply-to Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
	message dated "Wed, 25 Jan 2017 17:29:54 +0530"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5994.1485351168.1@sss.pgh.pa.us>
Date: Wed, 25 Jan 2017 08:32:48 -0500
Message-ID: <5995.1485351168@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Ashutosh Bapat <ashutosh.bapat@enterprisedb.com> writes:
> On Thu, Nov 3, 2016 at 1:58 PM, Jeevan Chalke
> <jeevan.chalke@enterprisedb.com> wrote:
>> Attached patch with test-case modification.

> I verified that this patch indeed bring the time down to 2 to 3
> seconds from 10 seconds.

Thanks for working on this, guys.

> The additional condition t2.c2 = 6 seems to echo the filter t2.c2 = 6
> of aggregate. We wouldn't know which of those actually worked. I
> modified the testcase to use t2.c2 % 6 = 0 instead and keep the filter
> condition intact. This increases the execution time by .2s, which may
> be ok. Let me know what you thing of the attached patch.

Agreed, that seems like a good compromise.  Pushed that way.

> Also, please add this to the commitfest, so that it isn't forgotten.

No need.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers