public inbox for [email protected]  
help / color / mirror / Atom feed
From: [email protected]
To: Heikki Linnakangas <[email protected]>
To: Andres Freund <[email protected]>
Cc: Tristan Partin <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Thomas Munro <[email protected]>
Subject: Re: Refactoring backend fork+exec code
Date: Mon, 29 Jan 2024 10:54:52 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On Thu, 2024-01-25 at 01:51 +0200, Heikki Linnakangas wrote:
> 
> And here we go. BackendID is now a 1-based index directly into the 
> PGPROC array.
> 

Would it be worthwhile to also note in this comment FIRST_AUX_PROC's
and IsAuxProcess()'s dependency on B_ARCHIVER and it's location in the
enum table?

      /*                                                                                                                              
      ¦* Auxiliary processes. These have PGPROC entries, but they are not                                                             
      ¦* attached to any particular database. There can be only one of each of                                                        
      ¦* these running at a time.                                                                                                     
      ¦*                                                                                                                              
      ¦* If you modify these, make sure to update NUM_AUXILIARY_PROCS and the                                                         
      ¦* glossary in the docs.                                                                                                        
      ¦*/                                                                                                                             
      B_ARCHIVER,                                                                                                                     
      B_BG_WRITER,                                                                                                                    
      B_CHECKPOINTER,                                                                                                                 
      B_STARTUP,                                                                                                                      
      B_WAL_RECEIVER,                                                                                                                 
      B_WAL_SUMMARIZER,                                                                                                               
      B_WAL_WRITER,                                                                                                                   
  } BackendType;                                                                                                                      
                                                                                                                                    
  #define BACKEND_NUM_TYPES (B_WAL_WRITER + 1)                        
                                                                                                                                      
  extern PGDLLIMPORT BackendType MyBackendType;                       
                                                                                                                                      
  #define FIRST_AUX_PROC B_ARCHIVER                                   
  #define IsAuxProcess(type)          (MyBackendType >= FIRST_AUX_PROC)





view thread (21+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Refactoring backend fork+exec code
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox