From: Antonin Houska <ah@cybertec.at>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>,
    vignesh C <vignesh21@gmail.com>,
    Srinath Reddy Sadipiralla <srinath2133@gmail.com>,
    Amit Kapila <amit.kapila16@gmail.com>,
    Mihail Nikalayeu <mihailnikalayeu@gmail.com>,
    Matthias van de Meent <boekewurm+postgres@gmail.com>,
    Pg Hackers <pgsql-hackers@lists.postgresql.org>,
    Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
In-reply-to: <202604062121.ijkompbo4ezj@alvherre.pgsql>
References: <202604062121.ijkompbo4ezj@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
   message dated "Mon, 06 Apr 2026 23:59:59 +0200."
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Date: Fri, 19 Jun 2026 08:48:51 +0200
Message-ID: <5998.1781851731@localhost>
Archived-At: 
 <https://www.postgresql.org/message-id/5998.1781851731%40localhost>
Precedence: bulk

--=-=-=
Content-Type: text/plain

This is a diff to remove a comment that was only valid in earlier versions of
the patch - I failed to notice that so far. Another comment in
copy_table_data() explains why rd_toastoid is not set in the CONCURRENTLY
mode:

	 * This would not work with CONCURRENTLY because we may need to delete
	 * TOASTed tuples from the new heap. With this hack, we'd delete them
	 * from the old heap.
	 */
	NewHeap->rd_toastoid = OldHeap->rd_rel->reltoastrelid;


-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com


--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment; filename=repack_comment.diff

diff --git a/src/backend/commands/repack.c b/src/backend/commands/repack.c
index 4d177c868bb..195d85c323b 100644
--- a/src/backend/commands/repack.c
+++ b/src/backend/commands/repack.c
@@ -1453,8 +1453,6 @@ copy_table_data(Relation NewHeap, Relation OldHeap, Relation OldIndex,
 
 	/*
 	 * Reset rd_toastoid just to be tidy --- it shouldn't be looked at again.
-	 * In the CONCURRENTLY case, we need to set it again before applying the
-	 * concurrent changes.
 	 */
 	NewHeap->rd_toastoid = InvalidOid;
 

--=-=-=--