Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dol8a-0001rG-Ck for pgsql-hackers@arkaria.postgresql.org; Mon, 04 Sep 2017 06:45:36 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dol8Z-00075I-Nf for pgsql-hackers@arkaria.postgresql.org; Mon, 04 Sep 2017 06:45:35 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dol8Z-000757-49 for pgsql-hackers@postgresql.org; Mon, 04 Sep 2017 06:45:35 +0000 Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]) by makus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dol8S-0001mT-0a for pgsql-hackers@postgresql.org; Mon, 04 Sep 2017 06:45:33 +0000 Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id v846jQJi005662 for ; Mon, 4 Sep 2017 15:45:26 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id A80295F63F; Mon, 4 Sep 2017 15:45:26 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 9BB2A5F593; Mon, 4 Sep 2017 15:45:26 +0900 (JST) Received: from [127.0.0.1] (unknown [129.60.241.68]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 8DAAD400863; Mon, 4 Sep 2017 15:45:26 +0900 (JST) Message-ID: <59ACF67D.6090002@lab.ntt.co.jp> Date: Mon, 04 Sep 2017 15:45:17 +0900 From: Tatsuro Yamada User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 Subject: Re: Minor code improvement to postgresGetForeignPlan References: <58E711AF.7070305@lab.ntt.co.jp> <57cea27a-822b-5333-a19d-c2e1045fe9a4@lab.ntt.co.jp> In-Reply-To: <57cea27a-822b-5333-a19d-c2e1045fe9a4@lab.ntt.co.jp> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit To: Etsuro Fujita , pgsql-hackers@postgresql.org X-TM-AS-MML: disable List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Hi Fujita-san, > The patch looks good to me, so I'll mark this as Ready for Committer. Thanks for reviewing my patch. > (I'm not sure we should do the same thing to the function declaration in other places such as fdwapi.h and the documentation for consistency, but if so, I'd vote for leaving that for another patch.) +1 Regards, Tatsuro Yamada -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers