Feedback-ID: i7c334307:Fastmail
Content-Type: multipart/signed;
	boundary="Apple-Mail=_F33EA439-276C-49A8-834E-57FD0C723ED1";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\))
Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim,
 replace, split_part
From: "David E. Wheeler" <david@justatheory.com>
In-Reply-To: <696ECBBC-3CBF-4522-AE66-E48225688E93@gmail.com>
Date: Mon, 26 May 2025 18:00:34 -0400
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
 Peter Eisentraut <peter@eisentraut.org>,
 Robert Haas <robertmhaas@gmail.com>,
 Alexander Korotkov <aekorotkov@gmail.com>,
 pgsql-hackers <pgsql-hackers@lists.postgresql.org>,
 Andrew Dunstan <andrew@dunslane.net>
Message-Id: <59C63857-406D-4704-A1EB-9BF3AA639C86@justatheory.com>
References: 
 <CA+v5N40sJF39m0v7h=QN86zGp0CUf9F1WKasnZy9nNVj_VhCZQ@mail.gmail.com>
 <145894.1727298237@sss.pgh.pa.us>
 <CAPpHfdtGhn_5jfLoepOScyqT+FXYB9QtV-OEprychDcMJco7mw@mail.gmail.com>
 <CA+v5N42PVJH3HbwLE1yC75XR6E5zGnCCdtSUXfgFwtGyPP8XYg@mail.gmail.com>
 <CA+Tgmob03B6h1SMsi7vs9uOX+vrqg_tyhh--mKC3BaTJ08qKYA@mail.gmail.com>
 <7e9debe6-4e96-4b0d-a801-b531e962ef43@eisentraut.org>
 <01DC1C38-0692-461B-AA63-5394330356BE@gmail.com>
 <2568904.1748022721@sss.pgh.pa.us>
 <D57D3B5E-AF55-4F7F-9E55-FE06EE8ED811@justatheory.com>
 <40912112-7FFE-400F-A38F-368827C4BDF1@gmail.com>
 <D201EEF7-8681-458E-B287-7B8F058DC712@justatheory.com>
 <176C517D-2DEB-4CAB-9AE4-261079D313B9@justatheory.com>
 <8FD5F4CF-9059-40C1-9F0A-C3CBA8DFE17A@justatheory.com>
 <C54B0664-34F5-46E2-9094-5798E68A2A3F@justatheory.com>
 <696ECBBC-3CBF-4522-AE66-E48225688E93@gmail.com>
To: Florents Tselai <florents.tselai@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/59C63857-406D-4704-A1EB-9BF3AA639C86%40justatheory.com>
Precedence: bulk


--Apple-Mail=_F33EA439-276C-49A8-834E-57FD0C723ED1
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

On May 25, 2025, at 00:16, Florents Tselai <florents.tselai@gmail.com> =
wrote:

> The most important problem in jsonpath_scan.l now is the fact that I =
broke the alphabetical ordering of keywords in v2 ,
> and you followed that too.

Oh. They have been organized by length; I didn=E2=80=99t notice they =
were also alphabetical.

> But you may be onto something with the split_part thing.

Yes, I think it would be best if the grammar was a bit stricter --- and =
therefore more self-explanatory --- by making the args closer to what =
the functions actually expect.

>> The existing string() method operates on a "JSON boolean, number, =
string, or datetime"; should these functions also operate on all those =
data types?
>=20
> You mean implicitely conversion to string first?
> I don=E2=80=99t think so: I=E2=80=99d expect to work like =
=E2=80=98$=E2=80=A6string().replace()=E2=80=A6'

Yes. Each of the existing methods has well-defined rules for what types =
of values they operate on, and many accept multiple types. Looking =
again, though, it appears that all the date/time methods operate only on =
strings, so I think you=E2=80=99re correct to follow that precedent and =
people can use `.string()` if they need it. We can also loosen it up =
later if use cases demand it.

>> I'm not sure how well these functions comply with the SQL spec.
>=20
> The fact that Peter hasn=E2=80=99t raized this as an issue, makes me =
think it's not one

Fair enough.

Best,

David


--Apple-Mail=_F33EA439-276C-49A8-834E-57FD0C723ED1
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEd+KfmbOQis6ZycGGkt9idPjIgfEFAmg05IIACgkQkt9idPjI
gfEOCA/8CqB6GD9FgvhugZKSBvRATMaGEGiLaA8kO2dSOEF14PtGJnXqewqBwXQh
iPt2SuvlddYJChpsWxn0dtT1z8l66td1UWoBAbvz1D2QqxWu8RkD0Ci0v6Dwg353
23dRhjQdnN0+M/ZtBRPaNLF1Wqb19xsagWLJSlww5uVXQqecfpp+5f9bGZB2vxrc
Vgwka3y4Nju6Ud6+OVXD+do5hgu3tb8swF983wrsbKPLnuwN9pcb9r5yD1RDNA3f
chyn+tF8A5ZCHtunkK4BvouzecZdJHqQaS2syIzCPjuQ0mDwUSfNF2ot03ECHIZq
4OYXrbWERlelFkM9WFNtyLHaTi9iAsLTCCd6Xv+QeH6f12uSx5N1t7esQdLo0IPT
GhDAfc8c99Wb2Qocgf95pcBcuJu0997KyHlI1SDP65LuZpIaa9z1I5BrfoNIJbBQ
LIM66J/X0kwZVBLXLsCdXJDtDhOSL21LCJ9BLaZx2PEMhk0XWfyQdS53Qbx1kHRf
xykA18MhgLIJOAWn+IBkj2ZDWZgzlygC5bY5+vCNfQ33ygR3hUoji0e9FDDfKtFH
QNCHoPEXwLsHA2pAOJ7NXyE78Vx8yWE5zRCPx+PTtTxdpI/kyYOEgl95Q2ySYvLS
Hr0V9ljlBWhc8kemPaA6fxPZysh3r7q7oh4ON91Mi0FwCbE1LIQ=
=ocnM
-----END PGP SIGNATURE-----

--Apple-Mail=_F33EA439-276C-49A8-834E-57FD0C723ED1--