Date: Thu, 14 Dec 2023 09:17:33 +0800
From: Zhang Mingli <zmlpostgres@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Message-ID: <59d61a1a-3858-475a-964f-24468c97cc67@Spark>
In-Reply-To: <b4f097ce-6422-49d7-888a-2e0a7a18f5f2@Spark>
References: <b4f097ce-6422-49d7-888a-2e0a7a18f5f2@Spark>
Subject: useless LIMIT_OPTION_DEFAULT
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="657a57b3_5922662c_d212"
Archived-At: <https://www.postgresql.org/message-id/59d61a1a-3858-475a-964f-24468c97cc67%40Spark>
Precedence: bulk

--657a57b3_5922662c_d212
Content-Type: multipart/alternative; boundary="657a57b3_4e1c0e1a_d212"

--657a57b3_4e1c0e1a_d212
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hi, all

By reading the codes, I found that we process limit option as LIMIT=5FOPT=
ION=5FWITH=5FTIES when using WITH TIES
and all others are LIMIT=5FOPTION=5FCOUNT by=C2=A0=C2=A0commit 357889eb17=
bb9c9336c4f324ceb1651da616fe57.
And check actual limit node in limit=5Fneeded().
There is no need to maintain a useless default limit enum.
I remove it and have an install check to verify.

Are there any considerations behind this=3F
Shall we remove it for clear as it=E2=80=99s not actually the default opt=
ion.


Zhang Mingli
www.hashdata.xyz

--657a57b3_4e1c0e1a_d212
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

<html xmlns=3D=22http://www.w3.org/1999/xhtml=22>
<head>
<title></title>
</head>
<body>
<div name=3D=22messageBodySection=22>
<div dir=3D=22auto=22>Hi, all<br />
<br />
By reading the codes, I found that we process limit option as LIMIT=5FOPT=
ION=5FWITH=5FTIES when using WITH TIES<br />
and all others are LIMIT=5FOPTION=5FCOUNT by&=23160;&=23160;commit 357889=
eb17bb9c9336c4f324ceb1651da616fe57.<br />
And check actual limit node in limit=5Fneeded().<br />
There is no need to maintain a useless default limit enum.&=23160;<br />
I remove it and have an install check to verify.<br />
<br />
Are there any considerations behind this=3F<br />
Shall we remove it for clear as it=E2=80=99s not actually the default opt=
ion.</div>
</div>
<div name=3D=22messageSignatureSection=22><br />
<div class=3D=22match=46ont=22>
<div dir=3D=22auto=22><br /></div>
Zhang Mingli
<div dir=3D=22auto=22><span style=3D=22color: var(--textColor); backgroun=
d-color: var(--backgroundColor);=22>www.hashdata.xyz</span><br /></div>
</div>
</div>
</body>
</html>

--657a57b3_4e1c0e1a_d212--

--657a57b3_5922662c_d212
Content-Type: application/octet-stream
Content-Transfer-Encoding: base64
Content-Disposition: attachment; 
 filename="=?utf-8?Q?v1-0001-Remove-useless-LIMIT=5FOPTION=5FDEFAULT.patch?="

RnJvbSA4MWU4MjI0ZDY4NTNlYzliNjAzZDYyMmYyOWQ5NWMwZTRlM2U3YWFjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBaaGFuZyBNaW5nbGkgPGF2YW1pbmdsaUBnbWFpbC5jb20+CkRh
dGU6IFRodSwgMTQgRGVjIDIwMjMgMDg6NTg6MDUgKzA4MDAKU3ViamVjdDogW1BBVENIXSBSZW1v
dmUgdXNlbGVzcyBMSU1JVF9PUFRJT05fREVGQVVMVC4KCldlIHByb2Nlc3MgbGltaXQgb3B0aW9u
IGFzIExJTUlUX09QVElPTl9XSVRIX1RJRVMgd2hlbiB1c2luZyBXSVRIIFRJRVMuCkFsbCBvdGhl
cnMgYXJlIExJTUlUX09QVElPTl9DT1VOVC4KQW5kIGNoZWNrIGFjdHVhbCBsaW1pdCBub2RlIGlu
IGxpbWl0X25lZWRlZCgpLgpUaGVyZSBpcyBubyBuZWVkIHRvIG1haW50YWluIGEgdXNlbGVzcyBk
ZWZhdWx0IGxpbWl0IGVudW0uCgpBdXRob3JlZC1ieTogWmhhbmcgTWluZ2xpIGF2YW1pbmdsaUBn
bWFpbC5jb20KLS0tCiBzcmMvYmFja2VuZC9wYXJzZXIvZ3JhbS55IHwgMiArLQogc3JjL2luY2x1
ZGUvbm9kZXMvbm9kZXMuaCB8IDMgKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygr
KSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9wYXJzZXIvZ3JhbS55
IGIvc3JjL2JhY2tlbmQvcGFyc2VyL2dyYW0ueQppbmRleCBmMTZiYmQzY2RkLi42M2YxNzJlMTc1
IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9wYXJzZXIvZ3JhbS55CisrKyBiL3NyYy9iYWNrZW5k
L3BhcnNlci9ncmFtLnkKQEAgLTE4NDYxLDcgKzE4NDYxLDcgQEAgaW5zZXJ0U2VsZWN0T3B0aW9u
cyhTZWxlY3RTdG10ICpzdG10LAogCQkJCQkgcGFyc2VyX2VycnBvc2l0aW9uKGV4cHJMb2NhdGlv
bihsaW1pdENsYXVzZS0+bGltaXRDb3VudCkpKSk7CiAJCXN0bXQtPmxpbWl0Q291bnQgPSBsaW1p
dENsYXVzZS0+bGltaXRDb3VudDsKIAl9Ci0JaWYgKGxpbWl0Q2xhdXNlICYmIGxpbWl0Q2xhdXNl
LT5saW1pdE9wdGlvbiAhPSBMSU1JVF9PUFRJT05fREVGQVVMVCkKKwlpZiAobGltaXRDbGF1c2Up
CiAJewogCQlpZiAoc3RtdC0+bGltaXRPcHRpb24pCiAJCQllcmVwb3J0KEVSUk9SLApkaWZmIC0t
Z2l0IGEvc3JjL2luY2x1ZGUvbm9kZXMvbm9kZXMuaCBiL3NyYy9pbmNsdWRlL25vZGVzL25vZGVz
LmgKaW5kZXggNGMzMjY4MmU0Yy4uNmU3NzZhOGFhNiAxMDA2NDQKLS0tIGEvc3JjL2luY2x1ZGUv
bm9kZXMvbm9kZXMuaAorKysgYi9zcmMvaW5jbHVkZS9ub2Rlcy9ub2Rlcy5oCkBAIC00MzksOCAr
NDM5LDcgQEAgdHlwZWRlZiBlbnVtIE9uQ29uZmxpY3RBY3Rpb24KIHR5cGVkZWYgZW51bSBMaW1p
dE9wdGlvbgogewogCUxJTUlUX09QVElPTl9DT1VOVCwJCQkvKiBGRVRDSCBGSVJTVC4uLiBPTkxZ
ICovCi0JTElNSVRfT1BUSU9OX1dJVEhfVElFUywJCS8qIEZFVENIIEZJUlNULi4uIFdJVEggVElF
UyAqLwotCUxJTUlUX09QVElPTl9ERUZBVUxULAkJLyogTm8gbGltaXQgcHJlc2VudCAqLworCUxJ
TUlUX09QVElPTl9XSVRIX1RJRVMJCS8qIEZFVENIIEZJUlNULi4uIFdJVEggVElFUyAqLwogfSBM
aW1pdE9wdGlvbjsKIAogI2VuZGlmCQkJCQkJCS8qIE5PREVTX0ggKi8KLS0gCjIuMzQuMQoK

--657a57b3_5922662c_d212--