Feedback-ID: ie0a040ee:Fastmail
Message-ID: <59ea426c-e31b-4b88-b970-eda808af9cc0@eisentraut.org>
Date: Wed, 17 Apr 2024 14:53:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: CREATE TABLE creates a composite type corresponding to the table
 row, which is and is not there
To: "David G. Johnston" <david.g.johnston@gmail.com>,
 Erik Wienhold <ewie@ewie.name>
Cc: Hannu Krosing <hannuk@google.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: 
 <CAMT0RQRysCb_Amy5CTENSc5GfsvXL1a4qX3mv_hx31_v74P==g@mail.gmail.com>
 <iafzaljqlx6bjbbhllavwgkg45lfj2mssm4xbazxezhpiitofe@k4g4fzcr6g2n>
 <nb4cfr26yhqfdirpkuwqxiaalfgloceuhfnmyor7w2pwgud5wl@c3mb7yd6uz4q>
 <itvvmotar2z565azdxbtsc7ajpymer6xmqc7tzifzw4zuxnxo6@puia7azj3x5c>
 <CAKFQuwYcV+AZMbyzHyDdxFhp_GH5Nty_GL1U5JkPYJeya0MLYQ@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CAKFQuwYcV+AZMbyzHyDdxFhp_GH5Nty_GL1U5JkPYJeya0MLYQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/59ea426c-e31b-4b88-b970-eda808af9cc0%40eisentraut.org>
Precedence: bulk

On 29.03.24 02:42, David G. Johnston wrote:
> We do use the term "stand-alone composite" in create type so I'm 
> inclined to use it instead of "composite created with CREATE TYPE"; 
> especially in the error messages; I'm a bit more willing to add the 
> cross-reference to create type in the user docs.

I'm not sure this would have helped.  If you see this in the error 
message, then there is no additional guidance what a "stand-alone 
composite type" and a not-"stand-alone composite type" are.

Maybe it's possible to catch the forbidden cases more explicitly and 
come up with more helpful error messages along the lines of "cannot 
create a typed table based on the row type of another table".