public inbox for [email protected]
help / color / mirror / Atom feedRe: Time to drop plpython2?
6+ messages / 4 participants
[nested] [flat]
* Re: Time to drop plpython2?
@ 2022-01-12 07:39 Peter Eisentraut <[email protected]>
2022-01-12 18:42 ` Re: Time to drop plpython2? Robert Haas <[email protected]>
2022-01-12 18:49 ` Re: Time to drop plpython2? Tom Lane <[email protected]>
0 siblings, 2 replies; 6+ messages in thread
From: Peter Eisentraut @ 2022-01-12 07:39 UTC (permalink / raw)
To: Tom Lane <[email protected]>; +Cc: Andres Freund <[email protected]>; pgsql-hackers
On 11.01.22 17:06, Tom Lane wrote:
> Nonetheless, we need to make a recommendation to the
> buildfarm owners about what's the minimum python3 version we intend
> to support going forward. Do we want to just set it at 3.6, with
> the expectation that the meson move will happen before too long?
Well, the minimum supported version has always been the oldest version
that actually works. I don't think we ever said, we support >= X, even
though < X still actually works, about any dependency.
I don't care much to tie this to Meson right now. Meson might well move
to 3.8 next week and ruin this whole scheme.
I'm okay with issuing some sort of recommendation for what is reasonable
to test, and 3.5 or 3.6 seems like a good cutoff, considering what LTS
OS currently ship. But I'm not sure if that is the same as "support".
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Time to drop plpython2?
2022-01-12 07:39 Re: Time to drop plpython2? Peter Eisentraut <[email protected]>
@ 2022-01-12 18:42 ` Robert Haas <[email protected]>
1 sibling, 0 replies; 6+ messages in thread
From: Robert Haas @ 2022-01-12 18:42 UTC (permalink / raw)
To: Peter Eisentraut <[email protected]>; +Cc: Tom Lane <[email protected]>; Andres Freund <[email protected]>; pgsql-hackers
On Wed, Jan 12, 2022 at 2:39 AM Peter Eisentraut
<[email protected]> wrote:
> Well, the minimum supported version has always been the oldest version
> that actually works. I don't think we ever said, we support >= X, even
> though < X still actually works, about any dependency.
I think that we sometimes say that versions < X are unsupported if we
are unable to test whether or not they work. In other words, I think
the relevant question is whether we are able to demonstrate that it
works, not whether it actually does work.
--
Robert Haas
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Time to drop plpython2?
2022-01-12 07:39 Re: Time to drop plpython2? Peter Eisentraut <[email protected]>
@ 2022-01-12 18:49 ` Tom Lane <[email protected]>
2022-01-13 15:02 ` Re: Time to drop plpython2? Peter Eisentraut <[email protected]>
1 sibling, 1 reply; 6+ messages in thread
From: Tom Lane @ 2022-01-12 18:49 UTC (permalink / raw)
To: Peter Eisentraut <[email protected]>; +Cc: Andres Freund <[email protected]>; pgsql-hackers
Peter Eisentraut <[email protected]> writes:
> On 11.01.22 17:06, Tom Lane wrote:
>> Nonetheless, we need to make a recommendation to the
>> buildfarm owners about what's the minimum python3 version we intend
>> to support going forward.
> Well, the minimum supported version has always been the oldest version
> that actually works. I don't think we ever said, we support >= X, even
> though < X still actually works, about any dependency.
The concern I have is how do we know what "actually works", if we're
not testing it? installation.sgml currently promises python2 >= 2.6,
and we know that that works because we have 2.6 in the buildfarm.
It also promises python3 >= 3.1, but we have no buildfarm animals
testing anything older than 3.4.3, so I don't think that promise
is worth the electrons it's written on. Furthermore, if the meson
conversion forces people to update their python3 to something newer,
there will probably be no testing of plpython against anything older
than what meson requires.
> I don't care much to tie this to Meson right now. Meson might well move
> to 3.8 next week and ruin this whole scheme.
Wouldn't be a problem unless our build scripts require that newer
version of meson. Andres mentioned earlier that we should be able
to run with some older meson versions that only require python 3.5
or so, so I'm hoping we can end up with directives like "use meson
X or later and python 3.5 or later".
> I'm okay with issuing some sort of recommendation for what is reasonable
> to test, and 3.5 or 3.6 seems like a good cutoff, considering what LTS
> OS currently ship. But I'm not sure if that is the same as "support".
Well, I'll see about putting 3.5 on my dinosaurs, and hope I don't
have to do it over.
Anyway, getting back to the point: I think we should notify the
owners ASAP and set a 30-day deadline. We should try to get this
done before the March CF starts, so it's too late for a 60-day
grace period. In any case, the worst-case scenario for an owner
is to disable --with-python until they have time to do an upgrade,
so it doesn't seem like a month is a big problem.
regards, tom lane
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Time to drop plpython2?
2022-01-12 07:39 Re: Time to drop plpython2? Peter Eisentraut <[email protected]>
2022-01-12 18:49 ` Re: Time to drop plpython2? Tom Lane <[email protected]>
@ 2022-01-13 15:02 ` Peter Eisentraut <[email protected]>
2022-01-13 17:00 ` Re: Time to drop plpython2? Tom Lane <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Peter Eisentraut @ 2022-01-13 15:02 UTC (permalink / raw)
To: Tom Lane <[email protected]>; +Cc: Andres Freund <[email protected]>; pgsql-hackers
On 12.01.22 19:49, Tom Lane wrote:
> Anyway, getting back to the point: I think we should notify the
> owners ASAP and set a 30-day deadline. We should try to get this
> done before the March CF starts, so it's too late for a 60-day
> grace period. In any case, the worst-case scenario for an owner
> is to disable --with-python until they have time to do an upgrade,
> so it doesn't seem like a month is a big problem.
Sure, let's do that. I don't have a buildfarm animal these days, so I'm
not on that list, so it would be great if you could do that
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Time to drop plpython2?
2022-01-12 07:39 Re: Time to drop plpython2? Peter Eisentraut <[email protected]>
2022-01-12 18:49 ` Re: Time to drop plpython2? Tom Lane <[email protected]>
2022-01-13 15:02 ` Re: Time to drop plpython2? Peter Eisentraut <[email protected]>
@ 2022-01-13 17:00 ` Tom Lane <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Tom Lane @ 2022-01-13 17:00 UTC (permalink / raw)
To: Peter Eisentraut <[email protected]>; +Cc: Andres Freund <[email protected]>; pgsql-hackers
Peter Eisentraut <[email protected]> writes:
> On 12.01.22 19:49, Tom Lane wrote:
>> Anyway, getting back to the point: I think we should notify the
>> owners ASAP and set a 30-day deadline.
> Sure, let's do that. I don't have a buildfarm animal these days, so I'm
> not on that list, so it would be great if you could do that
Done. I told them "mid February", so we can plan on say the 15th
as the target date for pushing a patch.
I realized BTW that the meson business is not relevant for prairiedog
or gaur. Those animals will die regardless of python version because
they can't build ninja (for lack of <spawn.h>). So I think maybe
I'll install python 3.1 and see if that compatibility claim is really
true ;-)
regards, tom lane
^ permalink raw reply [nested|flat] 6+ messages in thread
* [PATCH v1 1/2] use optimized linear search in TransactionIdIsInProgress
@ 2022-09-01 18:23 Nathan Bossart <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Nathan Bossart @ 2022-09-01 18:23 UTC (permalink / raw)
---
src/backend/storage/ipc/procarray.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/src/backend/storage/ipc/procarray.c b/src/backend/storage/ipc/procarray.c
index 0555b02a8d..a8b7b65518 100644
--- a/src/backend/storage/ipc/procarray.c
+++ b/src/backend/storage/ipc/procarray.c
@@ -58,6 +58,7 @@
#include "commands/dbcommands.h"
#include "miscadmin.h"
#include "pgstat.h"
+#include "port/pg_lfind.h"
#include "storage/proc.h"
#include "storage/procarray.h"
#include "storage/spin.h"
@@ -1586,14 +1587,9 @@ TransactionIdIsInProgress(TransactionId xid)
*/
topxid = SubTransGetTopmostTransaction(xid);
Assert(TransactionIdIsValid(topxid));
- if (!TransactionIdEquals(topxid, xid))
- {
- for (int i = 0; i < nxids; i++)
- {
- if (TransactionIdEquals(xids[i], topxid))
- return true;
- }
- }
+ if (!TransactionIdEquals(topxid, xid) &&
+ pg_lfind32(topxid, xids, nxids))
+ return true;
cachedXidIsNotInProgress = xid;
return false;
--
2.25.1
--HlL+5n6rz5pIUxbD
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="v1-0002-use-optimized-linear-search-in-XidIsConcurrent.patch"
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2022-09-01 18:23 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-01-12 07:39 Re: Time to drop plpython2? Peter Eisentraut <[email protected]>
2022-01-12 18:42 ` Robert Haas <[email protected]>
2022-01-12 18:49 ` Tom Lane <[email protected]>
2022-01-13 15:02 ` Peter Eisentraut <[email protected]>
2022-01-13 17:00 ` Tom Lane <[email protected]>
2022-09-01 18:23 [PATCH v1 1/2] use optimized linear search in TransactionIdIsInProgress Nathan Bossart <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox