Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJC6q-0004nr-4Q for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Nov 2017 05:37:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJC6p-0006UQ-CY for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Nov 2017 05:37:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eJC6p-0006UG-61 for pgsql-hackers@lists.postgresql.org; Mon, 27 Nov 2017 05:37:35 +0000 Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eJC6h-0001r6-JM for pgsql-hackers@postgresql.org; Mon, 27 Nov 2017 05:37:33 +0000 Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id vAR5bFHt022462; Mon, 27 Nov 2017 14:37:15 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 8CC0D60283; Mon, 27 Nov 2017 14:37:15 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 804045F594; Mon, 27 Nov 2017 14:37:15 +0900 (JST) Received: from [IPv6:::1] (unknown [129.60.241.75]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 782A84004EA; Mon, 27 Nov 2017 14:37:15 +0900 (JST) Message-ID: <5A1BA4C4.3060508@lab.ntt.co.jp> Date: Mon, 27 Nov 2017 14:38:12 +0900 From: Etsuro Fujita User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 Subject: Re: [HACKERS] Bug in ExecModifyTable function and trigger issues for foreign tables References: <20170514150525.0346ba72@postgrespro.ru> <20170516150516.1b616230@wp.localdomain> <20170615180548.5e142ddc@wp.localdomain> <0bc9c28b-96ca-c875-871e-16af6f53ecd9@lab.ntt.co.jp> <428f1672-df54-de01-91da-b57365193bf4@lab.ntt.co.jp> <6c651916-8fde-f9c9-b199-080df1bf2867@lab.ntt.co.jp> <280720c5-7aad-1136-6be3-654208c8f714@lab.ntt.co.jp> <8065.1500475011@sss.pgh.pa.us> <9cd25d80-08fc-568c-3181-dbe98723d0db@lab.ntt.co.jp> <3e9ff40d-d00f-3363-dcee-97ce023c7884@lab.ntt.co.jp> <14028.1511736992@sss.pgh.pa.us > In-Reply-To: <14028.1511736992@sss.pgh.pa.us> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit To: Tom Lane Cc: Ashutosh Bapat , Ildus Kurbangaliev , Dilip Kumar , PostgreSQL Hackers , Robert Haas X-TM-AS-MML: disable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk (2017/11/27 7:56), Tom Lane wrote: > Etsuro Fujita writes: >> [ fix-rewrite-tlist-v4.patch ] > > I started reviewing this patch. Great! > I did not much like the fact that it > effectively moved rewriteTargetListUD to a different file and renamed it. > That seems like unnecessary code churn, plus it breaks the analogy with > rewriteTargetListIU, plus it will make back-patching harder (since that > code isn't exactly the same in back branches). I see little reason why > we can't leave it where it is and just make it non-static. It's not like > there's no other parts of the rewriter that the planner calls. Agreed. Best regards, Etsuro Fujita