Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: Remove deprecated role membership options from psql help for
 CREATE USER/GROUP
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <MEAPR01MB3031C30E72EF16CFC08C8565B687A@MEAPR01MB3031.ausprd01.prod.outlook.com>
Date: Wed, 7 Jan 2026 17:30:16 +0800
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <5A39E825-95E5-40E9-98DC-22D89240B39F@gmail.com>
References: <MEAPR01MB3031C30E72EF16CFC08C8565B687A@MEAPR01MB3031.ausprd01.prod.outlook.com>
To: Japin Li <japinli@hotmail.com>
Archived-At: <https://www.postgresql.org/message-id/5A39E825-95E5-40E9-98DC-22D89240B39F%40gmail.com>
Precedence: bulk


> On Jan 6, 2026, at 18:16, Japin Li <japinli@hotmail.com> wrote:
>=20
>=20
> Hi,
>=20
> When I review [1], I found commit 8e78f0a1 deprecated the IN GROUP and =
USER
> clauses in CREATE ROLE, and also removed IN GROUP and USER from the =
psql \h
> CREATE ROLE help output.
>=20
> However, the psql help for the legacy synonyms CREATE USER and CREATE =
GROUP
> still lists the deprecated options:
>=20
> - IN GROUP role_name [, ...]
> - USER role_name [, ...]
>=20
> postgres=3D# \h create role
> Command:     CREATE ROLE
> Description: define a new database role
> Syntax:
> CREATE ROLE name [ [ WITH ] option [ ... ] ]
>=20
> where option can be:
>=20
>      SUPERUSER | NOSUPERUSER
>    | CREATEDB | NOCREATEDB
>    | CREATEROLE | NOCREATEROLE
>    | INHERIT | NOINHERIT
>    | LOGIN | NOLOGIN
>    | REPLICATION | NOREPLICATION
>    | BYPASSRLS | NOBYPASSRLS
>    | CONNECTION LIMIT connlimit
>    | [ ENCRYPTED ] PASSWORD 'password' | PASSWORD NULL
>    | VALID UNTIL 'timestamp'
>    | IN ROLE role_name [, ...]
>    | ROLE role_name [, ...]
>    | ADMIN role_name [, ...]
>    | SYSID uid
>=20
> URL: https://www.postgresql.org/docs/devel/sql-createrole.html
>=20
> postgres=3D# \h create user
> Command:     CREATE USER
> Description: define a new database role
> Syntax:
> CREATE USER name [ [ WITH ] option [ ... ] ]
>=20
> where option can be:
>=20
>      SUPERUSER | NOSUPERUSER
>    | CREATEDB | NOCREATEDB
>    | CREATEROLE | NOCREATEROLE
>    | INHERIT | NOINHERIT
>    | LOGIN | NOLOGIN
>    | REPLICATION | NOREPLICATION
>    | BYPASSRLS | NOBYPASSRLS
>    | CONNECTION LIMIT connlimit
>    | [ ENCRYPTED ] PASSWORD 'password' | PASSWORD NULL
>    | VALID UNTIL 'timestamp'
>    | IN ROLE role_name [, ...]
>    | IN GROUP role_name [, ...]
>    | ROLE role_name [, ...]
>    | ADMIN role_name [, ...]
>    | USER role_name [, ...]
>    | SYSID uid
>=20
> URL: https://www.postgresql.org/docs/devel/sql-createuser.html
>=20
> postgres=3D# \h create group
> Command:     CREATE GROUP
> Description: define a new database role
> Syntax:
> CREATE GROUP name [ [ WITH ] option [ ... ] ]
>=20
> where option can be:
>=20
>      SUPERUSER | NOSUPERUSER
>    | CREATEDB | NOCREATEDB
>    | CREATEROLE | NOCREATEROLE
>    | INHERIT | NOINHERIT
>    | LOGIN | NOLOGIN
>    | REPLICATION | NOREPLICATION
>    | BYPASSRLS | NOBYPASSRLS
>    | CONNECTION LIMIT connlimit
>    | [ ENCRYPTED ] PASSWORD 'password' | PASSWORD NULL
>    | VALID UNTIL 'timestamp'
>    | IN ROLE role_name [, ...]
>    | IN GROUP role_name [, ...]
>    | ROLE role_name [, ...]
>    | ADMIN role_name [, ...]
>    | USER role_name [, ...]
>    | SYSID uid
>=20
> URL: https://www.postgresql.org/docs/devel/sql-creategroup.html
>=20
> Since CREATE USER is documented as equivalent to CREATE ROLE WITH =
LOGIN, and
> CREATE GROUP is equivalent to CREATE ROLE, their help syntax should =
remain
> consistent with CREATE ROLE.
>=20
> I propose removing the deprecated IN GROUP and USER lines from the =
help text
> of both CREATE USER and CREATE GROUP. This would be a simple =
documentation
> cleanup that aligns the psql help with current reality and avoids =
confusing
> users with obsolete syntax.
>=20
> [1] =
https://www.postgresql.org/message-id/4c5f895e-3281-48f8-b943-9228b7da6471=
%40gmail.com
>=20
> --=20
> Regards,
> Japin Li
> ChengDu WenWu Information Technology Co., Ltd.
>=20
> <v1-0001-Remove-deprecated-role-options-for-CREATE-USER-GR.patch>


```
This commit removes the deprecated IN GROUP and USER lines from the psql
help output for CREATE USER and CREATE GROUP.
```

The commit message claims to remove things from psql help output, but =
the change actually updated the SGML docs. Does the patch miss the =
change on psql?

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/