Message-ID: <5A70396A.8090400@lab.ntt.co.jp>
Date: Tue, 30 Jan 2018 18:22:50 +0900
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:11.0) Gecko/20120327 Thunderbird/11.0.1
MIME-Version: 1.0
Subject: Re: non-bulk inserts and tuple routing
References: <8975331d-d961-cbdd-f862-fdd3d97dc2d0@lab.ntt.co.jp>
 <f3a0d60e-1f60-f2ea-dd6e-89c397e4ecf4@lab.ntt.co.jp>
 <CA+TgmoZM7S8cakW4j4b5xOz=p3ZOaMJTK-zd8ca8Gh9gY-17Tw@mail.gmail.com>
 <56c9f77b-830c-4652-233e-a1c5fa5a9938@lab.ntt.co.jp>
 <8f53a342-e0df-4fc9-7422-c3c3c601117c@lab.ntt.co.jp>
 <5A69A3B7.10403@lab.ntt.co.jp>
 <37f7cc10-def8-b2d0-615d-dfe035e7b1ee@lab.ntt.co.jp>
In-Reply-To: <37f7cc10-def8-b2d0-615d-dfe035e7b1ee@lab.ntt.co.jp>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: pgsql-hackers@lists.postgresql.org
Precedence: bulk

(2018/01/25 18:52), Amit Langote wrote:
> On 2018/01/25 18:30, Etsuro Fujita wrote:
>> The patches apply cleanly and compile successfully, but make check fails
>> in an assert-enabled build.
>
> Hmm, I can't seem to reproduce the failure with v4 patches I posted
> earlier today.

> Can you please post the errors you're seeing?

A quick debug showed that the failure was due to a segmentation fault 
caused by this change to ExecSetupPartitionTupleRouting (in patch 
v4-0003-During-tuple-routing-initialize-per-partition-obj):

-	bool		is_update = false;

+	bool		is_update;

I modified that patch to initialize the is_update to false as before. 
With the modified version, make check passed successfully.

I'll review the patch in more detail!

Best regards,
Etsuro Fujita