Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ej0P4-00048z-F6 for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Feb 2018 10:23:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ej0P2-0008AL-UI for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Feb 2018 10:23:04 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ej0P2-0008AA-KN for pgsql-hackers@lists.postgresql.org; Tue, 06 Feb 2018 10:23:04 +0000 Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ej0Ot-000822-Iz for pgsql-hackers@postgresql.org; Tue, 06 Feb 2018 10:23:01 +0000 Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w16AMqb6006786 for ; Tue, 6 Feb 2018 19:22:52 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id CC613EA84EC for ; Tue, 6 Feb 2018 19:22:52 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id C209DEA84BC for ; Tue, 6 Feb 2018 19:22:52 +0900 (JST) Received: from [IPv6:::1] (unknown [129.60.241.75]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id BF6AC400B05 for ; Tue, 6 Feb 2018 19:22:52 +0900 (JST) Message-ID: <5A7981EA.8020201@lab.ntt.co.jp> Date: Tue, 06 Feb 2018 19:22:34 +0900 From: Etsuro Fujita User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 Subject: Incorrect grammar Content-Type: multipart/mixed; boundary="------------070907040301040807050105" X-CC-Mail-RelayStamp: 1 To: Pg Hackers X-TM-AS-MML: disable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------070907040301040807050105 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Hi, While reviewing the lazy-initialization-of-partition-info-for-tuple-routing patch, I ran into a grammar mistake in a comment in ExecSetupChildParentMapForLeaf. Attached is a patch for fixing that. Best regards, Etsuro Fujita --------------070907040301040807050105 Content-Type: text/x-diff; name="fix-incorrect-grammar.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fix-incorrect-grammar.patch" diff --git a/src/backend/executor/execPartition.c b/src/backend/executor/execPartition.c index 106a96d..ba6b52c 100644 --- a/src/backend/executor/execPartition.c +++ b/src/backend/executor/execPartition.c @@ -360,7 +360,7 @@ ExecSetupChildParentMapForLeaf(PartitionTupleRouting *proute) Assert(proute != NULL); /* - * These array elements gets filled up with maps on an on-demand basis. + * These array elements get filled up with maps on an on-demand basis. * Initially just set all of them to NULL. */ proute->child_parent_tupconv_maps = --------------070907040301040807050105--