Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ejf9w-0003CO-IJ for pgsql-hackers@arkaria.postgresql.org; Thu, 08 Feb 2018 05:54:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ejf9v-0002Sb-95 for pgsql-hackers@arkaria.postgresql.org; Thu, 08 Feb 2018 05:54:11 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ejf9v-0002SR-25 for pgsql-hackers@lists.postgresql.org; Thu, 08 Feb 2018 05:54:11 +0000 Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ejf9n-0001MX-Na for pgsql-hackers@postgresql.org; Thu, 08 Feb 2018 05:54:10 +0000 Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w185rwNs028617; Thu, 8 Feb 2018 14:53:58 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id D7BFD638CB0; Thu, 8 Feb 2018 14:53:58 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id CC1E7638C9F; Thu, 8 Feb 2018 14:53:58 +0900 (JST) Received: from [IPv6:::1] (unknown [129.60.241.75]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id BB6D1400730; Thu, 8 Feb 2018 14:53:58 +0900 (JST) Message-ID: <5A7BE5E2.6040306@lab.ntt.co.jp> Date: Thu, 08 Feb 2018 14:53:38 +0900 From: Etsuro Fujita User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 Subject: Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly References: <5A438A45.2000909@lab.ntt.co.jp> <5A57193A.2080003@lab.ntt.co.jp> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: Robert Haas Cc: Pg Hackers , Rushabh Lathia , Michael Paquier , Ashutosh Bapat X-TM-AS-MML: disable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk (2018/02/08 5:39), Robert Haas wrote: > On Thu, Jan 11, 2018 at 2:58 AM, Etsuro Fujita > wrote: >> (2017/12/27 20:55), Etsuro Fujita wrote: >>> Attached is an updated version of the patch. >> >> I revised code/comments a little bit. PFA new version. > > I spent a while reading through this today. I see a few decisions > here or there that are debatable, in the sense that somebody else > might have chosen to do it differently, but I don't see anything that > actually looks wrong. So, committed. Thanks for committing, Robert! Thanks for reviewing, Rushabh and Ashutosh! Best regards, Etsuro Fujita