Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ejfMF-0003zm-0V for pgsql-hackers@arkaria.postgresql.org; Thu, 08 Feb 2018 06:06:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ejfMD-0005pc-JR for pgsql-hackers@arkaria.postgresql.org; Thu, 08 Feb 2018 06:06:53 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ejfMD-0005pQ-9d for pgsql-hackers@lists.postgresql.org; Thu, 08 Feb 2018 06:06:53 +0000 Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ejfM6-0006cs-Kd for pgsql-hackers@postgresql.org; Thu, 08 Feb 2018 06:06:52 +0000 Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w1866hFs029107; Thu, 8 Feb 2018 15:06:43 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 1F535EA7E77; Thu, 8 Feb 2018 15:06:43 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 14A1DEA7E61; Thu, 8 Feb 2018 15:06:43 +0900 (JST) Received: from [IPv6:::1] (unknown [129.60.241.75]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id EEDE54003BC; Thu, 8 Feb 2018 15:06:42 +0900 (JST) Message-ID: <5A7BE8E6.200@lab.ntt.co.jp> Date: Thu, 08 Feb 2018 15:06:30 +0900 From: Etsuro Fujita User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 Subject: Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly References: <5A438A45.2000909@lab.ntt.co.jp> <5A57193A.2080003@lab.ntt.co.jp> <6166.1518044513@sss.pgh.pa.us> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: Robert Haas Cc: Tom Lane , Pg Hackers , Rushabh Lathia , Michael Paquier , Ashutosh Bapat X-TM-AS-MML: disable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk (2018/02/08 10:40), Robert Haas wrote: > On Wed, Feb 7, 2018 at 6:01 PM, Tom Lane wrote: >> The buildfarm's opinion of it is lower than yours. Just eyeballing >> the failures, I'd say there was some naivete about the reproducibility >> of tuple CTIDs across different platforms. Is there a good reason >> these test cases need to print CTID? > > Uggh, I missed the fact that they were doing that. It's probably > actually useful test coverage, but it's not surprising that it isn't > stable. That was my purpose, but I agree with the instability. Thanks again, Robert! Best regards, Etsuro Fujita