Message-ID: <5A7CFDDA.8050906@lab.ntt.co.jp>
Date: Fri, 09 Feb 2018 10:48:10 +0900
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:11.0) Gecko/20120327 Thunderbird/11.0.1
MIME-Version: 1.0
Subject: Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join
 directly
References: <5A438A45.2000909@lab.ntt.co.jp> <5A57193A.2080003@lab.ntt.co.jp>
 <CA+TgmoYef9czAA1gJeqh4v47Tv=dqOp4EfdU6bV8EYkOdCwvUw@mail.gmail.com>
 <6166.1518044513@sss.pgh.pa.us>
 <CA+TgmoaxGGZyUAWQMz7c-3V85TV5-w2wmvpOYrLnALi2d9Z-dQ@mail.gmail.com>
 <5A7BE8E6.200@lab.ntt.co.jp> <28606.1518105934@sss.pgh.pa.us>
 <CA+Tgmobf+AXEwO4r0oCkvNhkaVnxPgoJaApoX+rAi0G7-N-Dyg@mail.gmail.com>
In-Reply-To: 
 <CA+Tgmobf+AXEwO4r0oCkvNhkaVnxPgoJaApoX+rAi0G7-N-Dyg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Pg Hackers <pgsql-hackers@postgresql.org>,
        Rushabh Lathia <rushabh.lathia@gmail.com>,
        Michael Paquier <michael.paquier@gmail.com>,
        Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Precedence: bulk

(2018/02/09 4:32), Robert Haas wrote:
> On Thu, Feb 8, 2018 at 11:05 AM, Tom Lane<tgl@sss.pgh.pa.us>  wrote:
>> According to
>>
>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rhinoceros&dt=2018-02-08%2001%3A45%3A01
>>
>> there's still an intermittent issue.  I ran "make installcheck" in
>> contrib/postgres_fdw in a loop, and got a similar failure on the
>> 47th try --- my result duplicates the second plan change shown by
>> rhinoceros, but not the first one.  I speculate that the plan change
>> is a result of autovacuum kicking in partway through the run.

Will look into this.

> Hmm.  Maybe inserting an ANALYZE command in the right place would fix it?

VACUUM to the right tables in the right place might better fix it? 
Another idea would be to modify test cases added by that commit so that 
they don't modify the existing tables to not break the existing test cases?

Best regards,
Etsuro Fujita