Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1esghO-0000AO-KJ for pgsql-hackers@arkaria.postgresql.org; Mon, 05 Mar 2018 03:22:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1esghN-00033Q-DS for pgsql-hackers@arkaria.postgresql.org; Mon, 05 Mar 2018 03:22:01 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1esghN-00033G-6J for pgsql-hackers@lists.postgresql.org; Mon, 05 Mar 2018 03:22:01 +0000 Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1esghJ-0004FJ-8E for pgsql-hackers@postgresql.org; Mon, 05 Mar 2018 03:22:00 +0000 Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w253LnkN004648; Mon, 5 Mar 2018 12:21:49 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id A1633639929; Mon, 5 Mar 2018 12:21:49 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 86D27639910; Mon, 5 Mar 2018 12:21:48 +0900 (JST) Received: from [IPv6:::1] (unknown [129.60.241.75]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 819034003C1; Mon, 5 Mar 2018 12:21:48 +0900 (JST) Message-ID: <5A9CB7B9.2040008@lab.ntt.co.jp> Date: Mon, 05 Mar 2018 12:21:29 +0900 From: Etsuro Fujita User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 Subject: Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly References: <5A438A45.2000909@lab.ntt.co.jp> <5A57193A.2080003@lab.ntt.co.jp> <6166.1518044513@sss.pgh.pa.us> <5A7BE8E6.200@lab.ntt.co.jp> <28606.1518105934@sss.pgh.pa.us> <5A7CFDDA.8050906@lab.ntt.co.jp> <5A7D76CF.8080601@lab.ntt.co.jp> <20134.1518201188@sss.pgh.pa.us> <18653.1518297871@sss.pgh.pa.us> <5A82DCCE.3060107@lab.ntt.co.jp> <29147.1519769644@sss.pgh.pa.us> <23783.1519929258@sss.pgh.pa.us> <5A9928F1.2010206@lab.ntt.co.jp> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: Robert Haas Cc: Tom Lane , Pg Hackers , Rushabh Lathia , Michael Paquier , Ashutosh Bapat X-TM-AS-MML: disable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk (2018/03/03 5:01), Robert Haas wrote: > On Fri, Mar 2, 2018 at 1:20 PM, Robert Haas wrote: >> On Fri, Mar 2, 2018 at 5:35 AM, Etsuro Fujita >> wrote: >>> Agreed. Better safe than sorry, so I disabled autovacuum for all the tables >>> created in the postgres_fdw regression test, except the ones with no data >>> modification created in the sections "test handling of collations" and "test >>> IMPORT FOREIGN SCHEMA". I'm attaching a patch for that. >> >> I have committed this patch. Whee! Thank you for taking the time on this! > And that seems to have made things worse. The failures on rhinocerous > look related: > > https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=rhinoceros&br=HEAD Totally outdated stats used in query planning causes the failures? ANALYZE right before the plan-changing queries would fix the failures? > And so does this failure on chub: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=chub&dt=2018-03-02%2016%3A10%3A02 The Git log shows that this was done before the commit. Best regards, Etsuro Fujita