Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1exM5i-0004Rs-8Z for pgsql-hackers@arkaria.postgresql.org; Sun, 18 Mar 2018 00:22:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1exM5f-0008JD-Js for pgsql-hackers@arkaria.postgresql.org; Sun, 18 Mar 2018 00:22:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1exM5f-0008J2-CC for pgsql-hackers@lists.postgresql.org; Sun, 18 Mar 2018 00:22:23 +0000 Received: from bay.acenet.us ([173.230.252.50]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1exM5b-00063S-S8 for pgsql-hackers@postgresql.org; Sun, 18 Mar 2018 00:22:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=anastigmatix.net; s=default; h=Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:Cc:References:To:Subject:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=cep2igw2hc/vYgZGRFv3l13OVamE+Y/7pfdXN+5Af+g=; b=BVcoqmDsiCs09Y6XPGmzuuz6R /IDOGpQorTlK4RdfCdatQ0tGKS2t/bskTPhdTVVvwB0NOR669HGNl6haMu3xyMExg5efLuMJDvvJ8 TyNOlG2hIpCPaniXJ6/ano4xLgrROlX/whjUpEu0fq1J+7y6dbS5DGFZvMYI1Q4xWbao0B6gLihE0 uwQEfFjtWhUW+fQsIT44IWsnEMmVaFGntkGwEpVcDTtJQv3oSaGDYLk80DmMCkptqhQwllmVZas7u 3Z86pq1RAxdHZ4ZzKNO79n3sXHdrKKYYzq0bz3ravmydJvt0uI+S89vF6KINDxaBAOXVd3kZIhqmn O8zupgrWQ==; Received: from [192.182.57.106] (port=49527) by bay.acenet.us with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89_1) (envelope-from ) id 1exM5R-003elV-2B; Sat, 17 Mar 2018 20:22:16 -0400 Subject: Re: [HACKERS] AdvanceXLInsertBuffer vs. WAL segment compressibility To: Daniel Gustafsson References: <579297F8.7020107@anastigmatix.net> <5797D953.6040806@anastigmatix.net> <20160802183347.GD32575@momjian.us> <20943eba-bbb9-390c-01b1-e6704ce33c7b@iki.fi> <594C9457.6000708@anastigmatix.net> <59506148.1010708@anastigmatix.net> <2b9ed9a4-56a6-a4db-0abf-3527d993e2d4@iki.fi> <5A92F0C0.7070706@anastigmatix.net> Cc: Michael Paquier , Heikki Linnakangas , Robert Haas , Bruce Momjian , PostgreSQL Hackers From: Chapman Flack X-Enigmail-Draft-Status: N1110 Message-ID: <5AADB130.2020206@anastigmatix.net> Date: Sat, 17 Mar 2018 20:22:08 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------080107040005020702070408" X-OutGoing-Spam-Status: No, score=-95.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bay.acenet.us X-AntiAbuse: Original Domain - postgresql.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - anastigmatix.net X-Get-Message-Sender-Via: bay.acenet.us: authenticated_id: chap+anastigmatix.net/only user confirmed/virtual account not confirmed X-Authenticated-Sender: bay.acenet.us: chap@anastigmatix.net X-Source: X-Source-Args: X-Source-Dir: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------080107040005020702070408 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 03/16/18 17:14, Daniel Gustafsson wrote: > The attached patch adds the test, and a neccessary extension to check_pg_config > to allow for extracting values from pg_config.h as opposed to just returning > the number of regex matches. (needed for XLOG_BLCKSZ.) Thanks for the review. I notice that cfbot has now flagged the patch as failing, and when I look into it, it appears that cfbot is building with your test patch, and without the xlog.c patch, and so the test naturally fails. Does the cfbot require both patches to be attached to the same email, in order to include them both? I'll try attaching both to this one, and see what it does. This is good confirmation that the test is effective. :) -Chap --------------080107040005020702070408 Content-Type: text/plain; charset=UTF-8; name="0001-Zero-headers-of-unused-pages-after-WAL-switch.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Zero-headers-of-unused-pages-after-WAL-switch.patch" RnJvbSAzNTY4NGJkYWExZDI3YzNmNGI3MTk4NTQxZjNjOTJiYjJiNGNiMmY0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDaGFwbWFuIEZsYWNrIDxjaGFwQGFuYXN0aWdtYXRp eC5uZXQ+CkRhdGU6IFN1biwgMjUgRmViIDIwMTggMTE6NDQ6NDcgLTA1MDAKU3ViamVjdDog W1BBVENIXSBaZXJvIGhlYWRlcnMgb2YgdW51c2VkIHBhZ2VzIGFmdGVyIFdBTCBzd2l0Y2gu CgpXaGVuIHdyaXRpbmcgemVyb2VkIHBhZ2VzIHRvIHRoZSByZW1haW5kZXIgb2YgYSBXQUwg c2VnbWVudAphZnRlciBhIFdBTCBzd2l0Y2gsIGVuc3VyZSB0aGF0IHRoZSBoZWFkZXJzIG9m IHRob3NlIHBhZ2VzIGFyZQphbHNvIHplcm9lZCwgYXMgdGhlaXIgaW5pdGlhbGl6ZWQgdmFs dWVzIG90aGVyd2lzZSByZWR1Y2UgdGhlCmNvbXByZXNzaWJpbGl0eSBvZiB0aGUgV0FMIHNl Z21lbnQgZmlsZSBieSBnZW5lcmFsIHRvb2xzLgotLS0KIHNyYy9iYWNrZW5kL2FjY2Vzcy90 cmFuc2FtL3hsb2cuYyB8IDExICsrKysrKysrKystCiAxIGZpbGUgY2hhbmdlZCwgMTAgaW5z ZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2Fj Y2Vzcy90cmFuc2FtL3hsb2cuYyBiL3NyYy9iYWNrZW5kL2FjY2Vzcy90cmFuc2FtL3hsb2cu YwppbmRleCA0N2E2YzRkLi5hOTFlYzdiIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9hY2Nl c3MvdHJhbnNhbS94bG9nLmMKKysrIGIvc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5zYW0veGxv Zy5jCkBAIC0xNTU2LDcgKzE1NTYsMTYgQEAgQ29weVhMb2dSZWNvcmRUb1dBTChpbnQgd3Jp dGVfbGVuLCBib29sIGlzTG9nU3dpdGNoLCBYTG9nUmVjRGF0YSAqcmRhdGEsCiAJCXsKIAkJ CS8qIGluaXRpYWxpemUgdGhlIG5leHQgcGFnZSAoaWYgbm90IGluaXRpYWxpemVkIGFscmVh ZHkpICovCiAJCQlXQUxJbnNlcnRMb2NrVXBkYXRlSW5zZXJ0aW5nQXQoQ3VyclBvcyk7Ci0J CQlBZHZhbmNlWExJbnNlcnRCdWZmZXIoQ3VyclBvcywgZmFsc2UpOworCQkJLyoKKwkJCSAq IEZpZWxkcyBpbiB0aGUgcGFnZSBoZWFkZXIgcHJlaW5pdGlhbGl6ZWQgYnkgQWR2YW5jZVhM SW5zZXJ0QnVmZmVyCisJCQkgKiB0byBub25jb25zdGFudCB2YWx1ZXMgcmVkdWNlIHRoZSBj b21wcmVzc2liaWxpdHkgb2YgV0FMIHNlZ21lbnRzLAorCQkJICogYW5kIGFyZW4ndCBuZWVk ZWQgaW4gdGhlIGZyZWVzcGFjZSBmb2xsb3dpbmcgYSBzd2l0Y2ggcmVjb3JkLgorCQkJICog UmUtemVybyB0aGF0IGhlYWRlciBhcmVhLiBUaGlzIGlzIG5vdCBwZXJmb3JtYW5jZS1jcml0 aWNhbCwgYXMKKwkJCSAqIHRoZSBtb3JlIGVtcHR5IHBhZ2VzIHRoZXJlIGFyZSBmb3IgdGhp cyBsb29wIHRvIHRvdWNoLCB0aGUgbGVzcworCQkJICogYnVzeSB0aGUgc3lzdGVtIGlzLgor CQkJICovCisJCQljdXJycG9zID0gR2V0WExvZ0J1ZmZlcihDdXJyUG9zKTsKKwkJCU1lbVNl dChjdXJycG9zLCAwLCBTaXplT2ZYTG9nU2hvcnRQSEQpOwogCQkJQ3VyclBvcyArPSBYTE9H X0JMQ0tTWjsKIAkJfQogCX0KLS0gCjIuNy4zCgo= --------------080107040005020702070408 Content-Type: text/plain; charset=UTF-8; name="wal_zeroed_test.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="wal_zeroed_test.patch" RnJvbSBhN2NiY2RlNzUxOGUyZjk1NjczZWM1ZGRiYTMyYjdlYTZlMGI4NGJiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBEYW5pZWwgR3VzdGFmc3NvbiA8ZGFuaWVsQHllc3Fs LnNlPgpEYXRlOiBGcmksIDE2IE1hciAyMDE4IDIxOjMyOjMyICswMTAwClN1YmplY3Q6IFtQ QVRDSF0gQWRkIHRlc3QgZm9yIGVuc3VyaW5nIFdBTCBzZWdtZW50IGlzIHplcm9lZCBvdXQK ClN3aXRjaCB0byBhIG5ldyBXQUwgZmlsZSBhbmQgZW5zdXJlIHRoZSBsYXN0IHNlZ21lbnQg aW4gdGhlIG5vdwpzd2l0Y2hlZC1hd2F5LWZyb20gZmlsZSBpcyBjb21wbGV0ZWx5IHplcm9l ZCBvdXQuCgpUaGlzIGFkZHMgYSBtb2RlIHRvIGNoZWNrX3BnX2NvbmZpZygpIHdoZXJlIHRo ZSBtYXRjaCBmcm9tIHRoZQpyZWdleHAgY2FuIGJlIHJldHVybmVkLCBub3QganVzdCB0aGUg bGl0ZXJhbCBjb3VudCBvZiBtYXRjaGVzLgpPbmx5IG9uZSBtYXRjaCBpcyByZXR1cm5lZCAo dGhlIGZpcnN0KSwgYnV0IGdpdmVuIHRoZSBzdHJ1Y3R1cmUKb2YgcGdfY29uZmlnLmggdGhh dCdzIGxpa2VseSB0byBiZSBlbm91Z2guCi0tLQogc3JjL3Rlc3QvcGVybC9UZXN0TGliLnBt ICAgICAgICAgICAgIHwgMTggKysrKysrKysrKysrKysrKy0tCiBzcmMvdGVzdC9yZWNvdmVy eS90LzAwMl9hcmNoaXZpbmcucGwgfCAyMCArKysrKysrKysrKysrKysrKysrLQogMiBmaWxl cyBjaGFuZ2VkLCAzNSBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL3NyYy90ZXN0L3BlcmwvVGVzdExpYi5wbSBiL3NyYy90ZXN0L3BlcmwvVGVzdExpYi5w bQppbmRleCA3ZDAxN2Q0OWJkLi44Yjk3OTZjNGY2IDEwMDY0NAotLS0gYS9zcmMvdGVzdC9w ZXJsL1Rlc3RMaWIucG0KKysrIGIvc3JjL3Rlc3QvcGVybC9UZXN0TGliLnBtCkBAIC0yMjcs MTUgKzIyNywyOSBAQCBzdWIgYXBwZW5kX3RvX2ZpbGUKICMgdGhhdC4KIHN1YiBjaGVja19w Z19jb25maWcKIHsKLQlteSAoJHJlZ2V4cCkgPSBAXzsKKwlteSAoJHJlZ2V4cCwgJHZhbHVl KSA9IEBfOwogCW15ICgkc3Rkb3V0LCAkc3RkZXJyKTsKKwlteSAkbWF0Y2g7CiAJbXkgJHJl c3VsdCA9IElQQzo6UnVuOjpydW4gWyAncGdfY29uZmlnJywgJy0taW5jbHVkZWRpcicgXSwg Jz4nLAogCSAgXCRzdGRvdXQsICcyPicsIFwkc3RkZXJyCiAJICBvciBkaWUgImNvdWxkIG5v dCBleGVjdXRlIHBnX2NvbmZpZyI7CiAJY2hvbXAoJHN0ZG91dCk7CiAKIAlvcGVuIG15ICRw Z19jb25maWdfaCwgJzwnLCAiJHN0ZG91dC9wZ19jb25maWcuaCIgb3IgZGllICIkISI7Ci0J bXkgJG1hdGNoID0gKGdyZXAgey9eJHJlZ2V4cC99IDwkcGdfY29uZmlnX2g+KTsKKwlpZiAo ZGVmaW5lZCAkdmFsdWUpCisJeworCQl3aGlsZSAoPCRwZ19jb25maWdfaD4pCisJCXsKKwkJ CSRfID1+IG0vXiRyZWdleHAvOworCQkJbmV4dCB1bmxlc3MgZGVmaW5lZCAkMTsKKwkJCSRt YXRjaCA9ICQxOworCQkJbGFzdDsKKwkJfQorCX0KKwllbHNlCisJeworCQkkbWF0Y2ggPSAo Z3JlcCB7L14kcmVnZXhwL30gPCRwZ19jb25maWdfaD4pOworCX0KIAljbG9zZSAkcGdfY29u ZmlnX2g7CiAJcmV0dXJuICRtYXRjaDsKIH0KZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlY292 ZXJ5L3QvMDAyX2FyY2hpdmluZy5wbCBiL3NyYy90ZXN0L3JlY292ZXJ5L3QvMDAyX2FyY2hp dmluZy5wbAppbmRleCBlMWJkM2M5NWNjLi5jMjM1ZTk4OTA0IDEwMDY0NAotLS0gYS9zcmMv dGVzdC9yZWNvdmVyeS90LzAwMl9hcmNoaXZpbmcucGwKKysrIGIvc3JjL3Rlc3QvcmVjb3Zl cnkvdC8wMDJfYXJjaGl2aW5nLnBsCkBAIC0zLDcgKzMsNyBAQCB1c2Ugc3RyaWN0OwogdXNl IHdhcm5pbmdzOwogdXNlIFBvc3RncmVzTm9kZTsKIHVzZSBUZXN0TGliOwotdXNlIFRlc3Q6 Ok1vcmUgdGVzdHMgPT4gMTsKK3VzZSBUZXN0OjpNb3JlIHRlc3RzID0+IDI7CiB1c2UgRmls ZTo6Q29weTsKIAogIyBJbml0aWFsaXplIG1hc3RlciBub2RlLCBkb2luZyBhcmNoaXZlcwpA QCAtNDksMyArNDksMjEgQEAgJG5vZGVfc3RhbmRieS0+cG9sbF9xdWVyeV91bnRpbCgncG9z dGdyZXMnLCAkY2F1Z2h0dXBfcXVlcnkpCiBteSAkcmVzdWx0ID0KICAgJG5vZGVfc3RhbmRi eS0+c2FmZV9wc3FsKCdwb3N0Z3JlcycsICJTRUxFQ1QgY291bnQoKikgRlJPTSB0YWJfaW50 Iik7CiBpcygkcmVzdWx0LCBxcSgxMDAwKSwgJ2NoZWNrIGNvbnRlbnQgZnJvbSBhcmNoaXZl cycpOworCisjIEFkZCBzb21lIGNvbnRlbnQsIHN3aXRjaCBXQUwgZmlsZSBhbmQgcmVhZCB0 aGUgbGFzdCBzZWdtZW50IG9mIHRoZSBXQUwKKyMgZmlsZSB3aGljaCBzaG91bGQgYmUgemVy b2VkIG91dAorbXkgJGN1cnJlbnRfZmlsZSA9ICRub2RlX21hc3Rlci0+c2FmZV9wc3FsKCdw b3N0Z3JlcycsCisJIlNFTEVDVCBwZ193YWxmaWxlX25hbWUocGdfY3VycmVudF93YWxfbHNu KCkpIik7Ciskbm9kZV9tYXN0ZXItPnNhZmVfcHNxbCgncG9zdGdyZXMnLCAiSU5TRVJUIElO VE8gdGFiX2ludCBWQUxVRVMgKDEpIik7Ciskbm9kZV9tYXN0ZXItPnNhZmVfcHNxbCgncG9z dGdyZXMnLCAiU0VMRUNUIHBnX3N3aXRjaF93YWwoKSIpOworCitteSAkeGxvZ19ibGNrc3og PSBjaGVja19wZ19jb25maWcoJyNkZWZpbmUgWExPR19CTENLU1ogKFxkKyknLCAxKTsKKwor b3BlbiBteSAkZmgsICc8OnJhdycsICRub2RlX21hc3Rlci0+ZGF0YV9kaXIgLiAnL3BnX3dh bC8nIC4gJGN1cnJlbnRfZmlsZTsKKyMgU0VFS19FTkQgaXMgZGVmaW5lZCBhcyAyLCBidXQg aXMgbm90IGFsbG93ZWQgd2hlbiB1c2luZyBzdHJpY3QgbW9kZQorc2VlayAkZmgsICgkeGxv Z19ibGNrc3ogKiAtMSksIDI7CitteSAkbGVuID0gcmVhZCgkZmgsIG15ICRieXRlcywgJHhs b2dfYmxja3N6KTsKK2Nsb3NlICRmaDsKKworbXkgKCR3YWxfc2VnbWVudCkgPSB1bnBhY2sg J04nIC4gJHhsb2dfYmxja3N6LCAkYnl0ZXM7Citpcygkd2FsX3NlZ21lbnQsIDAsICdtYWtl IHN1cmUgd2FsIHNlZ21lbnQgaXMgemVyb2VkJyk7Ci0tIAoyLjE0LjEuMTQ1LmdiMzYyMmE0 ZWUKCg== --------------080107040005020702070408--