Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f235d-0008AN-Vc for pgsql-hackers@arkaria.postgresql.org; Fri, 30 Mar 2018 23:05:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f235c-0001ZP-Ux for pgsql-hackers@arkaria.postgresql.org; Fri, 30 Mar 2018 23:05:44 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f235c-0001ZE-9A for pgsql-hackers@lists.postgresql.org; Fri, 30 Mar 2018 23:05:44 +0000 Received: from bay.acenet.us ([173.230.252.50]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f235Z-0003Nk-Mg for pgsql-hackers@postgresql.org; Fri, 30 Mar 2018 23:05:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=anastigmatix.net; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:Cc:References:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=jCH4yR8gFGWGjrH9prlmYhj5LknnTg3wqFKl9dO0SiA=; b=PgoKKaPX924r7OA2bDORnmbujO PQp5s1TYNklK40aBds8VsZBwKkufFjkdr8m2TKHsJqioevvZHYn2aE1HmbOq4R8UZPg/AP8ntV0If RVuRr0OKidL+Vcka0d2DUKl0J0vC2PV7nvjNxdA8xz74sdC1vqU6c0q355Gbf2WtMrVTu69VX1efh NEaupyYMds4ruqtCqHHpU5RrOb/jbHhQ08FnaeKZ/7H7CMPBTY1DwfA0KYy4bh6BcSEKjxA4YrKmW kLAbKMi3Zqmme/SO9BCLc1+VFF1cxZvKsUe+KAtoR0tZqCTtxEvovu7DiuKnbydbUtH9nyh8WE4bU fD2wfLMg==; Received: from [192.182.57.106] (port=60859) by bay.acenet.us with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89_1) (envelope-from ) id 1f235V-001bGN-II; Fri, 30 Mar 2018 19:05:38 -0400 Subject: Re: [HACKERS] AdvanceXLInsertBuffer vs. WAL segment compressibility To: Tom Lane , Stephen Frost References: <46FFB930-B0F3-400A-85ED-D9948C97FADF@yesql.se> <5AAEE00E.9050503@anastigmatix.net> <21C25ED8-4ED8-4AD4-B551-3E3987ECB18F@yesql.se> <5AAEFF11.3070903@anastigmatix.net> <20180326032731.GM24540@tamriel.snowman.net> <20180326054354.GB2759@paquier.xyz> <5ABAC668.5080203@anastigmatix.net> <8c00b26a-d6da-5764-e67e-9c4d8128081a@2ndquadrant.com> <5ABD9083.5050908@anastigmatix.net> <12915.1522433926@sss.pgh.pa.us> <20180330182423.GS24540@tamriel.snowman.net> <24353.1522441284@sss.pgh.pa.us> Cc: Tomas Vondra , Michael Paquier , Daniel Gustafsson , Michael Paquier , Heikki Linnakangas , Robert Haas , Bruce Momjian , PostgreSQL Hackers From: Chapman Flack Message-ID: <5ABEC2C0.5040207@anastigmatix.net> Date: Fri, 30 Mar 2018 19:05:36 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <24353.1522441284@sss.pgh.pa.us> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-OutGoing-Spam-Status: No, score=-100.2 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bay.acenet.us X-AntiAbuse: Original Domain - postgresql.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - anastigmatix.net X-Get-Message-Sender-Via: bay.acenet.us: authenticated_id: chap+anastigmatix.net/only user confirmed/virtual account not confirmed X-Authenticated-Sender: bay.acenet.us: chap@anastigmatix.net X-Source: X-Source-Args: X-Source-Dir: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 03/30/18 16:21, Tom Lane wrote: > Yup. Pushed with some rewriting of the comments. Thanks! > I did not like the proposed test case too much, particularly not its > undocumented API change for check_pg_config, Other than that API change, was there something the test case could have done differently to make you like it more? -Chap